-
Notifications
You must be signed in to change notification settings - Fork 59
Use 512-length filenames #343
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
ekluzek
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. This is nicely straightforward.
|
@jedwards4b and @billsacks this is ready to come in, after @samsrabin updates to the latest cdeps tag and redoes testing. Do you have any comments here? Or can he do that and then get this merged in afterwards? Let us know of changes you need, or other testing you'd like to have done. Thanks |
|
@samsrabin in light of the answer for #344, remove the DATAMODELTEST from: dglc/cime_config/testdefs/testlist_dglc.xml |
|
You just want to remove the DATAMODELTEST tests. |
|
Yes, sorry I got it backwards. Remove the DATAMODETEST from: dglc/cime_config/testdefs/testlist_dglc.xml I've corrected it above. |
Resolves ESCOMP#344
|
@ekluzek Done! |
billsacks
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this change - basically looks good. I see that you changed nlfilename and streamfilename for some data models but not others. Should this be consistent? See also the one inline comment below.
|
Good catches, @billsacks. Those are now addressed, and re-testing has |
billsacks
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good now - thanks for these changes that add more consistency!
Description of changes
Increases filename length in many places from 256 (
CL) to 512 (CX). This was necessary to support a new test that ended up generating very long file paths (see ESCOMP/CTSM#3292).I'm planning to merge in the latest CDEPS tag once I get an initial review.
Specific notes
Contributors other than yourself, if any: None
CDEPS Issues Fixed:
Are there dependencies on other component PRs (if so list): No
Are changes expected to change answers (bfb, different to roundoff, more substantial): bfb
Any User Interface Changes (namelist or namelist defaults changes): No
Testing performed (e.g. aux_cdeps, CESM prealpha, etc):
One CTSM test that was previously failing due to long file paths now passes.
aux_cdepstests all pass except two that aren't the result of this work:SMS_D_Ld3.f10_f10_ais8gris4_mg37.DATAMODELTEST.derecho_gnu: fails becauseDATAMODELTESTisn't a valid compset name (This is issue aux_cdeps test for DATAMODELTEST compset fails #344)SMS_Ld3.f19_g17_rx1.2000_SATM_SLND_SICE_SOCN_DROF%NYF_SGLC_SWAV.derecho_intel: fails with "ERROR: no alias f19_g17_rx1 defined" (This is issue aux_cdeps test using f19_g17_rx1 fails, because no longer defined in ccs_config #345)Hashes used for testing: 0595593