Skip to content

Conversation

@leepc12
Copy link

@leepc12 leepc12 commented Dec 14, 2021

  • Prevent collision between annotation names
  • Increase the threshold of LoD (level of detail) for blending of annotation names to prevent fading-out too fast at higher LoD (zoomed-out).

Fixes:

@leepc12 leepc12 requested a review from emro December 15, 2021 21:11
Copy link

@emro emro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks awesome! Most of my comments have to do with style conventions. Do you have a JS linting program installed? It can be really helpful.

The collision detection looks like it works really well. When I looked at your demo yesterday I saw a couple of overlaps but when I looked at it today I didn't see any.

One thing I was thinking could be another good change would be to not have the labels faded at the first zoom level at which they appear. They could just be black and then they'd be a lot more readable. I'm not sure what the use of having them faded is since they're not overlapping.

Copy link

@zoldello zoldello left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@leepc12 I have a comment marked as - Let's talk about. Let's talk about it. While I think the solution is clever, it does not solve the problem. I want to check with you to see if I am wrong. The other comments are minor Javascript rules.

Copy link

@emro emro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor typo that I'd rather fix.

Also, can we make a release with this update?

@emro emro self-requested a review January 14, 2022 01:53
@leepc12 leepc12 requested a review from emro January 28, 2022 17:33
Copy link

@emro emro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@emro emro merged commit 2d77999 into dev Feb 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants