Skip to content

Use React Native Packager xcode script for build phase #778

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jan 26, 2016
Merged

Use React Native Packager xcode script for build phase #778

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
df70227
Adds dependencies
aaronschachter Jan 25, 2016
067e523
Use packager/react-native-xcode.sh for build phase, move index.ios.js…
aaronschachter Jan 26, 2016
07531a6
Use valid package name
aaronschachter Jan 26, 2016
96ac788
Removes main.jsbundle per http://facebook.github.io/react-native/docs…
aaronschachter Jan 26, 2016
cf23c9e
Rename directory as ReactComponents
aaronschachter Jan 26, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions Lets Do This.xcodeproj/project.pbxproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,6 @@
B211C4221C3AF54800A94E64 /* LDTCauseListViewController.m in Sources */ = {isa = PBXBuildFile; fileRef = B211C4211C3AF54800A94E64 /* LDTCauseListViewController.m */; };
B212C2621B4ED6F300376BB1 /* LDTBaseViewController.m in Sources */ = {isa = PBXBuildFile; fileRef = B212C2611B4ED6F300376BB1 /* LDTBaseViewController.m */; };
B21306FC1C486E5C003893DB /* LDTNewsArticleViewController.m in Sources */ = {isa = PBXBuildFile; fileRef = B21306FB1C486E5C003893DB /* LDTNewsArticleViewController.m */; };
B21307001C487F92003893DB /* main.jsbundle in Resources */ = {isa = PBXBuildFile; fileRef = B21306FF1C487F92003893DB /* main.jsbundle */; };
B216CFC61B685EE8007E1914 /* UIImageView+LDT.m in Sources */ = {isa = PBXBuildFile; fileRef = B216CFC51B685EE8007E1914 /* UIImageView+LDT.m */; };
B21996B11B7CFEDA0054EADC /* LDTHeaderCollectionReusableView.m in Sources */ = {isa = PBXBuildFile; fileRef = B21996AF1B7CFEDA0054EADC /* LDTHeaderCollectionReusableView.m */; };
B21996B21B7CFEDA0054EADC /* LDTHeaderCollectionReusableView.xib in Resources */ = {isa = PBXBuildFile; fileRef = B21996B01B7CFEDA0054EADC /* LDTHeaderCollectionReusableView.xib */; };
Expand Down Expand Up @@ -128,7 +127,6 @@
B212C2611B4ED6F300376BB1 /* LDTBaseViewController.m */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.objc; name = LDTBaseViewController.m; path = Base/LDTBaseViewController.m; sourceTree = "<group>"; };
B21306FA1C486E5C003893DB /* LDTNewsArticleViewController.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; name = LDTNewsArticleViewController.h; path = News/LDTNewsArticleViewController.h; sourceTree = "<group>"; };
B21306FB1C486E5C003893DB /* LDTNewsArticleViewController.m */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.objc; name = LDTNewsArticleViewController.m; path = News/LDTNewsArticleViewController.m; sourceTree = "<group>"; };
B21306FF1C487F92003893DB /* main.jsbundle */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = text; path = main.jsbundle; sourceTree = "<group>"; };
B216CFC41B685EE8007E1914 /* UIImageView+LDT.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = "UIImageView+LDT.h"; sourceTree = "<group>"; };
B216CFC51B685EE8007E1914 /* UIImageView+LDT.m */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.objc; path = "UIImageView+LDT.m"; sourceTree = "<group>"; };
B21996AE1B7CFEDA0054EADC /* LDTHeaderCollectionReusableView.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = LDTHeaderCollectionReusableView.h; sourceTree = "<group>"; };
Expand Down Expand Up @@ -501,7 +499,6 @@
C2B1521F1ACE05510028C336 /* Views */,
C2B152191ACE05510028C336 /* Controllers */,
C2B151FC1ACE04C30028C336 /* Images.xcassets */,
B21306FF1C487F92003893DB /* main.jsbundle */,
C2B151FE1ACE04C30028C336 /* LaunchScreen.xib */,
B260387E1B44F84D002FE362 /* Resources */,
C2B151EC1ACE04C30028C336 /* Supporting Files */,
Expand Down Expand Up @@ -760,7 +757,6 @@
B23E68271B8FC74E005BFB5E /* LDTCampaignDetailReportbackItemCell.xib in Resources */,
B24FE0331BAA49CE001CAD5D /* LDTSubmitReportbackView.xib in Resources */,
B273A7691B459BBA00CBD4E1 /* Brandon_bld.otf in Resources */,
B21307001C487F92003893DB /* main.jsbundle in Resources */,
B23E68221B8FC728005BFB5E /* LDTCampaignDetailCampaignCell.xib in Resources */,
B27AF0E71B4F493D00164926 /* LDTProfileView.xib in Resources */,
B2A1365B1B3C9FDA00D20273 /* LDTUserConnectView.xib in Resources */,
Expand Down Expand Up @@ -853,7 +849,7 @@
);
runOnlyForDeploymentPostprocessing = 0;
shellPath = /bin/sh;
shellScript = "DEST=$CONFIGURATION_BUILD_DIR/$UNLOCALIZED_RESOURCES_FOLDER_PATH\n\nreact-native bundle \\\n--entry-file ReactComponent/index.ios.js \\\n--platform ios \\\n--dev false \\\n--bundle-output \"$DEST/main.jsbundle\" \\\n--assets-dest \"$DEST\"";
shellScript = "export NODE_BINARY=node\n\"$PWD/node_modules/react-native/packager/react-native-xcode.sh\"\n";
};
EA1F559F1BFF7D0D00AD98D8 /* Run New Relic Script */ = {
isa = PBXShellScriptBuildPhase;
Expand Down
0 ReactComponent/helpers.js → ReactComponents/Helpers.js
View file
Open in desktop
File renamed without changes.
2 changes: 1 addition & 1 deletion ReactComponent/index.ios.js → index.ios.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ import React, {
View
} from 'react-native';

var Helpers = require('./helpers.js');
var Helpers = require('./ReactComponents/Helpers.js');

var TAKE_ACTION_TEXT = 'Take action';

Expand Down
7 changes: 5 additions & 2 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"name": "letsdothis-ios",
"name": "letsdothis_ios",
"version": "1.0.3",
"description": "Let's Do This (iOS)",
"main": "index.js",
Expand All @@ -16,5 +16,8 @@
"bugs": {
"url": "https://github.com/DoSomething/LetsDoThis-iOS/issues"
},
"homepage": "https://github.com/DoSomething/LetsDoThis-iOS#readme"
"homepage": "https://github.com/DoSomething/LetsDoThis-iOS#readme",
"dependencies": {
"react-native": "^0.18.1"
}
}