This repository was archived by the owner on Feb 15, 2022. It is now read-only.
Drop obsolete ROI calc in darwin to avoid glitches #1258
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DeviaVir
pushed a commit
that referenced
this pull request
Feb 1, 2018
Heerpa
pushed a commit
to Heerpa/zenbot
that referenced
this pull request
Feb 25, 2018
Heerpa
pushed a commit
to Heerpa/zenbot
that referenced
this pull request
Feb 25, 2018
ROI is used in the status display This brings back the ROI and fixes the glitch reference in DeviaVir#1258
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
roicalculation in darwin.js does nothing but dump to the generation's json file. It's not used for fitness calcs or anything, it's just extra stuff. The problem with it is that if you run a backtest withcurrency_capital == 0andasset_capital > 0then it'll crash because it doesn't know how to computeroiwithout any starting currency. There's lots and lots of ideas about how to get the right information to calculate this correctly, but there's already plenty of other values actually being displayed and used for comparison's sake besidesroiso it's easier to just get rid of this.To see it crash for yourself, here's the command: