This repository was archived by the owner on Feb 15, 2022. It is now read-only.
Fix training start and simulation start/end #1119
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
buy_max_amt was working only on live, now it works also on paper mode
Get rid of that annoying message. Telegram tested and working fine.
Previously the training was starting too early if --days_test was specified. According to the parameter description, --days_test is a parameter to specify when the simulation should stop (days after training). The simulator wants the start and end date in this format: YYYYMMDDhhmm, which was not the case, thus the simulator wasn't running properly. Now if the user specifies dates it works properly. Example: ./zenbot.sh train binance.ETH-BTC --start_training 2018-01-01 --end_training 2018-01-03 --days_test 3 In this example, the training stops on Jan 2nd (midnight). The simulation test runs after the period used in the training, thus begins on on Jan 3rd and stops 3 days later, on Jan 5th (midnight).
DeviaVir
approved these changes
Jan 13, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.