This repository was archived by the owner on Feb 15, 2022. It is now read-only.
Corrected engine.js to include held assets in calculations for buy_max_amt and buy_pct #1111
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
T-rav
changed the title
Contributor
Author
|
Going to close this pull request. I have merged my changed into the unstable branch and will redo the pull request from unstable to unstable branches. This should fix the merge conflicts in package-lock.json |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will stop the behavior described in this issue #878
and fix it for when the bot is running in standard mode too.
It is not perfect because it uses the current quote price in calculation, thus large price fluctuations can impact its correctness.