fix: Use NPM OIDC #1150
fix: Use NPM OIDC #1150
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
There was a problem hiding this comment.
Pull Request Overview
Switches publication flow to rely on (implied) npm OIDC by removing manual OTP handling and token secret injection. Key changes simplify the publish script and workflow but also remove explicit authentication validation.
- Removed OTP argument parsing, auth wrapper function, and auth presence check in npm-safe-publish.sh
- Replaced npm_authenticated call with direct npm publish
- Cleared NODE_AUTH_TOKEN secret mapping in release workflow
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| scripts/npm-safe-publish.sh | Removes OTP/token handling and publishes directly with npm |
| .github/workflows/release.yml | Removes NODE_AUTH_TOKEN secret mapping (empty secrets_map) |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| while (( "$#" )); do | ||
| case "$1" in | ||
| --otp=*) | ||
| OTP="${1#*=}" | ||
| shift | ||
| ;; | ||
| --dry-run) | ||
| DRY_RUN="true" | ||
| echo "Dry run enabled. Not pushing to NPM." |
There was a problem hiding this comment.
Removal of the previously supported --otp=... argument is a breaking CLI change; existing automation invoking the script with --otp= will now fail as an unknown argument. Consider retaining a no-op handler for --otp (emitting a deprecation warning) to preserve backward compatibility, e.g.: case --otp=* ) echo 'Warning: --otp deprecated; OIDC in use.' ;;
Copilot uses AI. Check for mistakes.
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
JamieSinn
force-pushed
the
use-npm-oidc
branch
from
1747066 to
916fa58
Compare
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 8 out of 8 changed files in this pull request and generated no new comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
1 participant
No description provided.