feat: Issue 262: OpenFeatureAPI usage precludes use of proprietary features #263
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@nnoel-grubhub thanks for making this PR, yea we certainly missed making the DevCycleClient available through the Provider. That is an expected behaviour that we also have on the iOS Provider: https://github.com/DevCycleHQ/ios-openfeature-provider/blob/main/Sources/DevCycleProvider.swift#L29C30-L29C44 Will review and get released |
nnoel-grubhub
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#262
While the OpenFeature API is of course meant to serve as a portable abstraction that can be used across numerous feature providers, customers may want to leverage some proprietary features of DevCycle where necessary while still abstracting the main functionality of checking feature variable values behind OpenFeature.
It would be useful to allow access to the underlying DevCycleClient from DevCycleProvider instances. For example, we need access to the allFeatures method for analytics purposes, but this is not available via OpenFeatureAPI.
I noticed that you expose the underlying DevCycle Client in the Web Client. This would be useful in the Android SDK as well.
This PR simply adds a getter for the underlying DevCycleClient