chore: cleanup unnecessary JSON properties and annotations

[jonathannorris]

The JSON parsing library was audited to ensure unknown properties are ignored globally.

• It was confirmed that JSONMapper.kt is configured with DeserializationFeature.FAIL_ON_UNKNOWN_PROPERTIES set to false, which globally ignores unknown JSON properties during deserialization.
• Consequently, all redundant @JsonIgnoreProperties(ignoreUnknown = true) annotations were removed from the following model classes:
  • BucketedUserConfig.kt
  • Variable.kt
  • ConfigVariable.kt (6 instances across abstract and concrete classes)
  • SSE.kt
  • ProjectSettings.kt
  • Project.kt
  • Feature.kt
  • ErrorResponse.kt
  • Environment.kt
  • EdgeDB.kt
  • DevCycleUser.kt
• Unused import com.fasterxml.jackson.annotation.JsonIgnoreProperties statements were also removed.
• Other JSON annotations (@JsonProperty, @JsonInclude, @JsonFormat, @JsonDeserialize) were retained as they serve distinct, necessary purposes for serialization, formatting, and custom deserialization logic.

[Copilot]

Pull Request Overview

This PR cleans up the models by removing redundant @JsonIgnoreProperties annotations now that the global JSON configuration ignores unknown properties. It also updates several classes to Kotlin data classes for improved readability and consistency, and removes unused imports.

• Removed redundant JSON annotations from multiple model classes.
• Converted regular classes to data classes.
• Removed unused or unnecessary import statements.

Reviewed Changes

Copilot reviewed 11 out of 11 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
Variable.kt	Removed unused JSON annotation and updated comment formatting.
SSE.kt	Removed JSON annotation and converted class to a data class.
ProjectSettings.kt	Removed JSON annotation and converted class to a data class.
Project.kt	Removed JSON annotation and converted class to a data class.
Feature.kt	Removed JSON annotation and converted class to a data class.
ErrorResponse.kt	Removed JSON annotation and replaced with a wildcard import.
Environment.kt	Removed JSON annotation, converted class to a data class, and reformatted code.
EdgeDB.kt	Removed JSON annotation and converted class to a data class.
DevCycleUser.kt	Removed JSON annotation from the Builder and converted class to a data class.
ConfigVariable.kt	Removed JSON annotations from multiple variable classes.
BucketedUserConfig.kt	Removed redundant JSON annotation.

[jonathannorris]

this is interesting that this was missing...

[jonathannorris]

[jonathannorris]

I guess do we want these to be data classes?

[kaushalkapasi]

yeah, I just made the same update in my PR #240. though it does need some refactoring to make sure everything compiles, the test data is updated and all test pass appropriately