feat: Update Cached Config Logic to Support User-specific Caching and 30-day TTL #226
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: jonathannorris <[email protected]>
Copilot
AI
changed the title
[WIP] Update Cached Config Logic
Update Cached Config Logic to Support User-specific Caching and 30-day TTL
May 28, 2025
Copilot finished work on behalf of
jonathannorris
May 28, 2025 17:54
android-client-sdk/src/main/java/com/devcycle/sdk/android/util/DVCSharedPrefs.kt
Outdated
Show resolved
Hide resolved
jonathannorris
changed the title
JamieSinn
reviewed
Jun 3, 2025
Comment on lines
75
to
78
| editor.remove(legacyKey) | ||
| editor.remove(legacyUserIdKey) | ||
| editor.remove(legacyFetchDateKey) | ||
| migrationOccurred = true |
There was a problem hiding this comment.
shouldn't you remove regardless if a subset of the data exists?
There was a problem hiding this comment.
Good point! I've updated the migration logic to clean up legacy keys regardless of whether we can migrate them completely. Now we check for each legacy key individually and remove it if it exists, preventing orphaned keys from staying in SharedPreferences. Added test coverage for this scenario as well. See commit e0a2b6c.
Co-authored-by: JamieSinn <[email protected]>
|
Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details. Warning Firewall rules blocked me from connecting to one or more addressesI tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
Copilot finished work on behalf of
JamieSinn
June 3, 2025 13:57
jsalaber
approved these changes
Jun 3, 2025
suthar26
approved these changes
Jun 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR enhances how configuration data is cached in the Android Client SDK to standardize behavior across all DevCycle client SDKs. The improvements focus on three key areas:
Fixes #225.
Warning
Firewall rules blocked me from connecting to one or more addresses
I tried to connect to the following addresses, but was blocked by firewall rules:
dl.google.com/usr/lib/jvm/temurin-17-jdk-amd64/bin/java --add-opens=java.base/java.util=ALL-UNNAMED --add-opens=java.base/java.lang=ALL-UNNAMED --add-opens=java.base/java.lang.invoke=ALL-UNNAMED --add-opens=java.prefs/java.util.prefs=ALL-UNNAMED --add-opens=java.base/java.nio.charset=ALL-UNNAMED --add-opens=java.base/java.net=ALL-UNNAMED --add-opens=java.base/java.util.concurrent.atomic=ALL-UNNAMED -Xmx2048m -Dfile.encoding=UTF-8 -Duser.country -Duser.language=en -Duser.variant -cp /home/REDACTED/.gradle/wrapper/dists/gradle-8.5-bin/5t9huq95ubn472n8rpzujfbqh/gradle-8.5/lib/gradle-launcher-8.5.jar -javaagent:/home/REDACTED/.gradle/wrapper/dists/gradle-8.5-bin/5t9huq95ubn472n8rpzujfbqh/gradle-8.5/lib/agents/gradle-instrumentation-agent-8.5.jar org.gradle.launcher.daemon.bootstrap.GradleDaemon 8.5(dns block)If you need me to access, download, or install something from one of these locations, you can either:
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.