Skip to content

Conversation

@JAssertz
Copy link
Contributor

Changelog: fix an issue with compare when removing items would cause it to show all similar items to show.

fixes #11578

Copy link
Contributor

@bhollis bhollis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suppose this is a fix but how did the or get there in the first place?

@JAssertz
Copy link
Contributor Author

I suppose this is a fix but how did the or get there in the first place?

When you go to the search bar and search for ex 'exactname:boomslang-4fr or' the search accepts this as a valid search and the parseQuery function converts this to `exactname:boomslang-4fr and or'. When you remove an item it updates the base query to 'exactname:boomslang-4fr or -id:{id}'

@bhollis
Copy link
Contributor

bhollis commented Oct 26, 2025

Sounds like the original query should be invalid

@JAssertz JAssertz marked this pull request as draft November 2, 2025 00:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Removing item in Comparison drawer instead selects everything (with weird filter)

2 participants