WIP: exotic class item perk picker for loadout optimizer #11518
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FlaminSarge
commented
Sep 20, 2025
| return updateLoadout(state, setLoadoutParameters({ exoticArmorHash: undefined })); | ||
| return updateLoadout( | ||
| state, | ||
| setLoadoutParameters({ exoticArmorHash: undefined, perks: [] }), |
There was a problem hiding this comment.
This would somehow need to be aware of which perks to remove when an exo class item is removed, instead of just wiping them entirely.
FlaminSarge
commented
Sep 20, 2025
Comment on lines
+574
to
+579
| for (const r of removed) { | ||
| const index = perks.indexOf(r); | ||
| if (index !== -1) { | ||
| perks.splice(index, 1); | ||
| } | ||
| } |
There was a problem hiding this comment.
I couldn't find a better way to do this that worked with the 'multiple instances of a perk' handling.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #11352
Changelog: Add the ability to select exotic class item perks in Loadout Optimizer