Skip to content

Conversation

@0rierel
Copy link
Contributor

@0rierel 0rierel commented Aug 23, 2025

Please fill in this template.

Select one of these and delete the others:

If adding a new definition:

  • The package does not already provide its own types, or cannot have its .d.ts files generated via --declaration
  • If this is for an npm package, match the name. If not, do not conflict with the name of an npm package.
  • Create it with dts-gen --dt, not by basing it on an existing project.
  • Represents shape of module/library correctly
  • tsconfig.json should have noImplicitAny, noImplicitThis, strictNullChecks, and strictFunctionTypes set to true.

@typescript-bot
Copy link
Contributor

typescript-bot commented Aug 23, 2025

@0rierel Thank you for submitting this PR! I see this is your first time submitting to DefinitelyTyped 👋 — I'm the local bot who will help you through the process of getting things through.

This is a live comment that I will keep updated.

1 package in this PR

Code Reviews

This PR adds a new definition, so it needs to be reviewed by a DT maintainer before it can be merged.

You can test the changes of this PR in the Playground.

Status

  • ✅ No merge conflicts
  • ✅ Continuous integration tests have passed
  • ✅ Only a DT maintainer can approve changes when there are new packages added

All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes.


Diagnostic Information: What the bot saw about this PR
{
  "type": "info",
  "now": "-",
  "pr_number": 73532,
  "author": "0rierel",
  "headCommitOid": "72a41e79f0e6955221a23bea39d9b49903564e00",
  "mergeBaseOid": "d65f24c95e732e4b0eadaebf63f5699801a05e59",
  "lastPushDate": "2025-08-23T19:57:24.000Z",
  "lastActivityDate": "2025-09-03T11:40:54.000Z",
  "mergeOfferDate": "2025-09-03T02:58:01.000Z",
  "mergeRequestDate": "2025-09-03T11:40:54.000Z",
  "mergeRequestUser": "0rierel",
  "hasMergeConflict": false,
  "isFirstContribution": true,
  "tooManyFiles": false,
  "hugeChange": false,
  "popularityLevel": "Well-liked by everyone",
  "pkgInfo": [
    {
      "name": "net-snmp",
      "kind": "add",
      "files": [
        {
          "path": "types/net-snmp/.npmignore",
          "kind": "package-meta-ok"
        },
        {
          "path": "types/net-snmp/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/net-snmp/net-snmp-tests.ts",
          "kind": "test"
        },
        {
          "path": "types/net-snmp/package.json",
          "kind": "package-meta-ok"
        },
        {
          "path": "types/net-snmp/tsconfig.json",
          "kind": "package-meta-ok"
        }
      ],
      "owners": [],
      "addedOwners": [
        "0rierel"
      ],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    }
  ],
  "reviews": [
    {
      "type": "approved",
      "reviewer": "RyanCavanaugh",
      "date": "2025-09-03T02:57:21.000Z",
      "isMaintainer": true
    }
  ],
  "mainBotCommentID": 3217307165,
  "ciResult": "pass"
}

@typescript-bot typescript-bot added New Definition This PR creates a new definition package. Edits Infrastructure labels Aug 23, 2025
@typescript-bot typescript-bot moved this to Waiting for Code Reviews in Pull Request Status Board Aug 23, 2025
@typescript-bot
Copy link
Contributor

🔔 @0rierel — you're the only owner, but it would still be good if you find someone to review this PR in the next few days, otherwise a maintainer will look at it. (And if you do find someone, maybe even recruit them to be a second owner to make future changes easier...)

@typescript-bot typescript-bot added the The CI failed When GH Actions fails label Aug 23, 2025
@typescript-bot
Copy link
Contributor

@0rierel The CI build failed! Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

Note: builds that are failing do not end up on the list of PRs for the DT maintainers to review.

@typescript-bot typescript-bot moved this from Waiting for Code Reviews to Needs Author Action in Pull Request Status Board Aug 23, 2025
@typescript-bot typescript-bot removed the The CI failed When GH Actions fails label Aug 23, 2025
@typescript-bot typescript-bot moved this from Needs Author Action to Waiting for Code Reviews in Pull Request Status Board Aug 23, 2025
@typescript-bot typescript-bot moved this from Waiting for Code Reviews to Needs Maintainer Action in Pull Request Status Board Aug 23, 2025
@typescript-bot typescript-bot moved this from Needs Maintainer Action to Waiting for Code Reviews in Pull Request Status Board Aug 23, 2025
@typescript-bot typescript-bot moved this from Waiting for Code Reviews to Needs Maintainer Action in Pull Request Status Board Aug 23, 2025
@typescript-bot typescript-bot added Maintainer Approved Self Merge This PR can now be self-merged by the PR author or an owner labels Sep 3, 2025
@typescript-bot typescript-bot moved this from Needs Maintainer Action to Waiting for Author to Merge in Pull Request Status Board Sep 3, 2025
@typescript-bot
Copy link
Contributor

@0rierel: Everything looks good here. I am ready to merge this PR (at 72a41e7) on your behalf whenever you think it's ready.

If you'd like that to happen, please post a comment saying:

Ready to merge

and I'll merge this PR almost instantly. Thanks for helping out! ❤️

@0rierel
Copy link
Contributor Author

0rierel commented Sep 3, 2025

Ready to merge

@typescript-bot typescript-bot moved this from Waiting for Author to Merge to Recently Merged in Pull Request Status Board Sep 3, 2025
@typescript-bot typescript-bot merged commit 38d4223 into DefinitelyTyped:master Sep 3, 2025
4 checks passed
@0rierel 0rierel deleted the net-snmp branch September 3, 2025 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Maintainer Approved New Definition This PR creates a new definition package. Self Merge This PR can now be self-merged by the PR author or an owner

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants