Skip to content

Conversation

@naveenkumarsangi
Copy link
Contributor

@naveenkumarsangi naveenkumarsangi commented Nov 20, 2018

  • Use a meaningful title for the pull request. Include the name of the package modified.
  • Test the change in your own code. (Compile and run.)
  • Add or edit tests to reflect the change. (Run with npm test.)
  • Follow the advice from the readme.
  • Avoid common mistakes.
  • Run npm run lint package-name (or tsc if no tslint.json is present).

If adding a new definition:

  • The package does not already provide its own types, or cannot have its .d.ts files generated via --declaration
  • If this is for an NPM package, match the name. If not, do not conflict with the name of an NPM package.
  • Create it with dts-gen --dt, not by basing it on an existing project.
  • tslint.json should be present, and tsconfig.json should have noImplicitAny, noImplicitThis, strictNullChecks, and strictFunctionTypes set to true.

@naveenkumarsangi naveenkumarsangi changed the title Add type definitions for netlify-widget-tests Add type definitions for netlify-identity-widget Nov 20, 2018
@naveenkumarsangi
Copy link
Contributor Author

As suggested by the package maintainer (@sw-yx) of netlify-identity-widget, the type definitions are expected to be maintained here.

@typescript-bot typescript-bot added the New Definition This PR creates a new definition package. label Nov 20, 2018
@typescript-bot
Copy link
Contributor

typescript-bot commented Nov 20, 2018

@nkprince007 Thank you for submitting this PR!

Because this is a new definition, a DefinitelyTyped maintainer will be reviewing this PR in the next few days once the Travis CI build passes.

In the meantime, if the build fails or a merge conflict occurs, I'll let you know. Have a nice day!

@typescript-bot typescript-bot added Revision needed This PR needs code changes before it can be merged. and removed Awaiting reviewer feedback labels Nov 20, 2018
@typescript-bot
Copy link
Contributor

@nkprince007 One or more reviewers has requested changes. Please address their comments. I'll be back once they sign off or you've pushed new commits or comments. Thank you!

@naveenkumarsangi
Copy link
Contributor Author

Thanks for the early review @uniqueiniquity. The response has been extremely timely. 👍

@typescript-bot
Copy link
Contributor

🔔 @uniqueiniquity - Thanks for your review of this PR! Can you please look at the new code and update your review status if appropriate?

@uniqueiniquity
Copy link
Contributor

Congratulations on your first DefinitelyTyped contribution!
Thank you for being a part of the community!

@uniqueiniquity uniqueiniquity merged commit ac7a57c into DefinitelyTyped:master Nov 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

New Definition This PR creates a new definition package. Revision needed This PR needs code changes before it can be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants