-
Notifications
You must be signed in to change notification settings - Fork 6.5k
Add Union TVL to escher project #16747
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 5 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
53cec41
feat: Add escher finance project
DVendy 3db1c1c
feat: Methodology text update
DVendy 0e59b34
Merge remote-tracking branch 'upstream/main'
DVendy 8fe68de
Add Union tvl to Escher project
DVendy 8978e5b
feat: update methodology
DVendy 4274484
Merge remote-tracking branch 'upstream/main'
DVendy d184cd6
feat: add union chain, use sdk query, new tvl method
DVendy 0170af3
Merge remote-tracking branch 'upstream/main'
DVendy File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please use our SDK for EVM TVLs. Maybe use staking() from our helpers. Also since this is your own token, please export this as
stakingrather thantvland usetvl: () => ({})Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hi @waynebruce0x thanks for the response. As for this initially we wanted to list it under union chain but it's not there yet so we listed under ethereum since our token currently only lives in ethereum.
Can you add the union chain? that way we can query using cosmos helper just like our eBABY
https://union.build/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you should add 'union' to chains.json and then export a balance of either ethereum:0xba5ed44733953d79717f6269357c77718c8ba5ed or coingecko:union-2 under tvl.union
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hi @waynebruce0x I've updated the code with :
I noticed that the build is failing, but it's not from our project folder