422 need for pylibtiff==051 pin #425
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Synchro with main
|
I'm merging it. This is the problem with GA scripts. |
martinfleis
reviewed
Jun 26, 2024
| @@ -1,8 +1,8 @@ | |||
| descartes | |||
| geopandas | |||
| geopandas>=1.0.0 | |||
There was a problem hiding this comment.
Sorry to be pain but this may actually cause other conflicts :D and I don't think you need a pin here at all.
There was a problem hiding this comment.
Ok, I will remove this pin ;)
| matplotlib | ||
| scikit-learn | ||
| numpy | ||
| numpy<2 |
There was a problem hiding this comment.
Yes, for now - pylibtiff throws me errors when numpy has the newest version.
|
I updated the package on PyPI and Conda-Forge ;) Thanks for your review and support! |
|
Thanks for a speedy response! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated dependencies
Package version (main branch)
version: 0.5.1
Description
Updated dependencies -
GeoPandasto version > 1, andpylibtiff> 0.6, andnumpy< 2Problem
Package won't work with GeoPandas, and this is a huge problem.
Solution
Updating dependencies.
Affected modules
Unit tests
Package check
(Optional) Additional info
Is feature related to literature? Does change require new dependencies? Any other information...