Allow templating in sortAscending and sortDescending ARIA strings #86
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Think looks like a fantastic addition - thanks! I'm not yet sure if I'll include it in 1.10.13, or the following. Let me get back to you on that - I should be able to confirm next week. |
|
Sorry for the delay in getting back to you here! I feel inclined to include this in the next major update (be that 1.11 or 2.0) rather than in 1.10 and simply do away with the option to not have Hopefully we aren't too far away from branching to the next major version, so I'll include this then. |
Avaruz
pushed a commit
to Avaruz/DataTablesSrc
that referenced
this pull request
Jan 15, 2024
…Tables.AspNet.Mvc5/Newtonsoft.Json-13.0.1 Bump Newtonsoft.Json from 9.0.1 to 13.0.1 in /src/DataTables.AspNet.Mvc5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ARIA labels for sortable columns are built using raw string concatenation. With this pull request, the same string templating that works in other components (like in pagination:
Showing page _PAGE_ of _PAGES_) can be used for both of these strings.I offer this contribution under the same license the project uses, the MIT license.