chore: Remove view optionality from Vital events #313
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xnm
approved these changes
Oct 22, 2025
rgaignault
approved these changes
Oct 22, 2025
aleksandr-gringauz
approved these changes
Oct 22, 2025
thomas-lebeau
approved these changes
Oct 22, 2025
BenoitZugmeyer
requested changes
Oct 22, 2025
Member
BenoitZugmeyer
left a comment
BenoitZugmeyer
left a comment
There was a problem hiding this comment.
Please see #315 for a fix that should accommodate all SDKs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What and why
This PR reverts #306, which made the view optional for vital events.
The topic will be revisited later to find a better solution that accommodates the requirements of all SDKs.