-
Notifications
You must be signed in to change notification settings - Fork 15
[Crashtracking] refactor sigpipe tests #1235
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Crashtracking] refactor sigpipe tests #1235
Conversation
|
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #1235 +/- ##
==========================================
+ Coverage 71.69% 71.75% +0.05%
==========================================
Files 354 354
Lines 56063 56103 +40
==========================================
+ Hits 40192 40254 +62
+ Misses 15871 15849 -22
🚀 New features to boost your workflow:
|
ca6ce02 to
7d53140
Compare
BenchmarksComparisonBenchmark execution time: 2025-09-22 13:40:50 Comparing candidate commit 07881eb in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 53 metrics, 2 unstable metrics. CandidateCandidate benchmark detailsGroup 1
Group 2
Group 3
Group 4
Group 5
Group 6
Group 7
Group 8
Group 9
Group 10
Group 11
Group 12
Group 13
Group 14
Group 15
BaselineOmitted due to size. |
e2847e2 to
cfa1296
Compare
6a49427 to
6e8239f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, FWIW
|
/merge |
|
View all feedbacks in Devflow UI.
The expected merge time in
|
What does this PR do?
We recently had some crashtracking tests break because of an upstream update with Rust, and how they deal with signal supression for
UnixStream. This PR moves the logic of triggering aSIGPIPEby writing to a pipe that has been dropped into a helper and writes a separate test for that test helper, so that if we have issues due toSIGPIPEbeing emitted ever again, we can pinpoint exactly what went wrong.Motivation
What inspired you to submit this pull request?
Additional Notes
Anything else we should know when reviewing?
How to test the change?
Refactored, and wrote a test for the new helper