Skip to content

Conversation

@gyuheon0h
Copy link
Contributor

@gyuheon0h gyuheon0h commented Sep 19, 2025

What does this PR do?

We recently had some crashtracking tests break because of an upstream update with Rust, and how they deal with signal supression for UnixStream. This PR moves the logic of triggering a SIGPIPE by writing to a pipe that has been dropped into a helper and writes a separate test for that test helper, so that if we have issues due to SIGPIPE being emitted ever again, we can pinpoint exactly what went wrong.

Motivation

What inspired you to submit this pull request?

Additional Notes

Anything else we should know when reviewing?

How to test the change?

Refactored, and wrote a test for the new helper

@datadog-official
Copy link

datadog-official bot commented Sep 19, 2025

⚠️ Tests

⚠️ Warnings

❄️ 1 New flaky test detected

test_ddog_sidecar_register_app from datadog-sidecar-ffi::sidecar (Datadog) (✨ Fix with BitsAI)
thread 'test_ddog_sidecar_register_app' panicked at D:\a\libdatadog\libdatadog\ddcommon-ffi\src\option.rs:34:32

thread 'test_ddog_sidecar_register_app' panicked at D:\a\libdatadog\libdatadog\ddcommon-ffi\src\option.rs:34:32:
Called ffi::Option::unwrap_none but option was Some(_)
stack backtrace:
   0:     0x7ff7f2097612 - std::backtrace_rs::backtrace::win64::trace
                               at /rustc/29483883eed69d5fb4db01964cdf2af4d86e9cb2/library\std\src\..\..\backtrace\src\backtrace\win64.rs:85
   1:     0x7ff7f2097612 - std::backtrace_rs::backtrace::trace_unsynchronized
                               at /rustc/29483883eed69d5fb4db01964cdf2af4d86e9cb2/library\std\src\..\..\backtrace\src\backtrace\mod.rs:66
   2:     0x7ff7f2097612 - std::sys::backtrace::_print_fmt
...

ℹ️ Info

🧪 All tests passed

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 6e8239f | Docs | Was this helpful? Give us feedback!

@codecov-commenter
Copy link

codecov-commenter commented Sep 19, 2025

Codecov Report

❌ Patch coverage is 85.89744% with 11 lines in your changes missing coverage. Please review.
✅ Project coverage is 71.75%. Comparing base (b827e80) to head (6e8239f).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1235      +/-   ##
==========================================
+ Coverage   71.69%   71.75%   +0.05%     
==========================================
  Files         354      354              
  Lines       56063    56103      +40     
==========================================
+ Hits        40192    40254      +62     
+ Misses      15871    15849      -22     
Components Coverage Δ
datadog-crashtracker 49.30% <ø> (ø)
datadog-crashtracker-ffi 5.93% <ø> (ø)
datadog-alloc 98.73% <ø> (ø)
data-pipeline 90.30% <ø> (ø)
data-pipeline-ffi 88.19% <ø> (ø)
ddcommon 84.29% <ø> (ø)
ddcommon-ffi 73.84% <ø> (ø)
ddtelemetry 60.02% <ø> (ø)
ddtelemetry-ffi 21.24% <ø> (ø)
dogstatsd-client 83.26% <ø> (ø)
datadog-ipc 82.39% <ø> (-0.11%) ⬇️
datadog-profiling 76.90% <ø> (ø)
datadog-profiling-ffi 62.12% <ø> (ø)
datadog-sidecar 37.08% <ø> (ø)
datdog-sidecar-ffi 11.37% <ø> (ø)
spawn-worker 55.35% <ø> (ø)
tinybytes 92.22% <ø> (ø)
datadog-trace-normalization 98.24% <ø> (ø)
datadog-trace-obfuscation 94.17% <ø> (ø)
datadog-trace-protobuf 77.10% <ø> (ø)
datadog-trace-utils 89.75% <ø> (ø)
datadog-tracer-flare 54.52% <ø> (ø)
datadog-log 76.31% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@gyuheon0h gyuheon0h force-pushed the gyuheon0h/prof-12581-refactor-sigpipe-test branch from ca6ce02 to 7d53140 Compare September 19, 2025 21:11
@pr-commenter
Copy link

pr-commenter bot commented Sep 19, 2025

Benchmarks

Comparison

Benchmark execution time: 2025-09-22 13:40:50

Comparing candidate commit 07881eb in PR branch gyuheon0h/prof-12581-refactor-sigpipe-test with baseline commit a7c8765 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 53 metrics, 2 unstable metrics.

Candidate

Candidate benchmark details

Group 1

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 07881eb 1758547681 gyuheon0h/prof-12581-refactor-sigpipe-test
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
benching string interning on wordpress profile execution_time 157.007µs 157.785µs ± 0.453µs 157.703µs ± 0.176µs 157.893µs 158.406µs 159.276µs 161.046µs 2.12% 3.250 17.041 0.29% 0.032µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
benching string interning on wordpress profile execution_time [157.723µs; 157.848µs] or [-0.040%; +0.040%] None None None

Group 2

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 07881eb 1758547681 gyuheon0h/prof-12581-refactor-sigpipe-test
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
credit_card/is_card_number/ execution_time 3.892µs 3.911µs ± 0.003µs 3.911µs ± 0.002µs 3.913µs 3.918µs 3.919µs 3.920µs 0.22% -0.470 6.384 0.08% 0.000µs 1 200
credit_card/is_card_number/ throughput 255117821.132op/s 255658427.688op/s ± 213107.851op/s 255690245.417op/s ± 115835.700op/s 255780980.261op/s 255918962.986op/s 255971695.271op/s 256968576.773op/s 0.50% 0.490 6.501 0.08% 15069.001op/s 1 200
credit_card/is_card_number/ 3782-8224-6310-005 execution_time 77.360µs 78.358µs ± 0.451µs 78.313µs ± 0.306µs 78.634µs 79.103µs 79.433µs 79.631µs 1.68% 0.217 -0.445 0.57% 0.032µs 1 200
credit_card/is_card_number/ 3782-8224-6310-005 throughput 12557858.124op/s 12762308.673op/s ± 73433.450op/s 12769266.929op/s ± 49923.588op/s 12816927.319op/s 12872657.981op/s 12911427.120op/s 12926553.545op/s 1.23% -0.192 -0.463 0.57% 5192.529op/s 1 200
credit_card/is_card_number/ 378282246310005 execution_time 70.766µs 71.247µs ± 0.305µs 71.187µs ± 0.198µs 71.405µs 71.843µs 72.090µs 72.293µs 1.55% 0.788 0.384 0.43% 0.022µs 1 200
credit_card/is_card_number/ 378282246310005 throughput 13832633.183op/s 14035980.367op/s ± 59807.077op/s 14047432.419op/s ± 39025.419op/s 14076307.815op/s 14119131.354op/s 14123944.749op/s 14131077.065op/s 0.60% -0.766 0.331 0.43% 4228.999op/s 1 200
credit_card/is_card_number/37828224631 execution_time 3.889µs 3.910µs ± 0.003µs 3.910µs ± 0.002µs 3.912µs 3.915µs 3.917µs 3.921µs 0.28% -1.273 12.566 0.08% 0.000µs 1 200
credit_card/is_card_number/37828224631 throughput 255032959.717op/s 255729541.085op/s ± 196489.335op/s 255740977.214op/s ± 118239.562op/s 255852385.592op/s 255952916.842op/s 256038724.663op/s 257143762.579op/s 0.55% 1.303 12.781 0.08% 13893.894op/s 1 200
credit_card/is_card_number/378282246310005 execution_time 67.737µs 68.448µs ± 0.310µs 68.428µs ± 0.211µs 68.640µs 68.959µs 69.351µs 69.627µs 1.75% 0.542 0.806 0.45% 0.022µs 1 200
credit_card/is_card_number/378282246310005 throughput 14362229.096op/s 14609912.147op/s ± 65970.700op/s 14613878.280op/s ± 45127.428op/s 14658624.571op/s 14707491.335op/s 14737909.580op/s 14763010.003op/s 1.02% -0.508 0.729 0.45% 4664.833op/s 1 200
credit_card/is_card_number/37828224631000521389798 execution_time 44.921µs 44.992µs ± 0.042µs 44.987µs ± 0.027µs 45.014µs 45.057µs 45.112µs 45.212µs 0.50% 1.355 3.994 0.09% 0.003µs 1 200
credit_card/is_card_number/37828224631000521389798 throughput 22118263.080op/s 22226285.295op/s ± 20558.478op/s 22228873.163op/s ± 13409.929op/s 22242103.804op/s 22252974.014op/s 22257490.931op/s 22261154.286op/s 0.15% -1.343 3.931 0.09% 1453.704op/s 1 200
credit_card/is_card_number/x371413321323331 execution_time 5.691µs 5.698µs ± 0.004µs 5.698µs ± 0.003µs 5.701µs 5.705µs 5.708µs 5.712µs 0.25% 0.611 0.196 0.07% 0.000µs 1 200
credit_card/is_card_number/x371413321323331 throughput 175079389.275op/s 175498821.189op/s ± 124577.477op/s 175514699.356op/s ± 88519.065op/s 175594311.707op/s 175677647.873op/s 175713711.099op/s 175730857.628op/s 0.12% -0.608 0.188 0.07% 8808.958op/s 1 200
credit_card/is_card_number_no_luhn/ execution_time 3.889µs 3.912µs ± 0.003µs 3.912µs ± 0.002µs 3.914µs 3.917µs 3.920µs 3.922µs 0.26% -1.201 9.358 0.09% 0.000µs 1 200
credit_card/is_card_number_no_luhn/ throughput 254968522.152op/s 255631439.572op/s ± 222354.465op/s 255633212.111op/s ± 140978.055op/s 255771609.515op/s 255920661.475op/s 255991365.577op/s 257138663.884op/s 0.59% 1.227 9.540 0.09% 15722.835op/s 1 200
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 execution_time 62.827µs 64.502µs ± 0.181µs 64.531µs ± 0.044µs 64.579µs 64.635µs 64.681µs 64.723µs 0.30% -5.304 39.696 0.28% 0.013µs 1 200
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 throughput 15450394.962op/s 15503609.531op/s ± 44129.040op/s 15496531.878op/s ± 10620.020op/s 15506377.385op/s 15586816.656op/s 15636981.252op/s 15916722.067op/s 2.71% 5.420 41.282 0.28% 3120.394op/s 1 200
credit_card/is_card_number_no_luhn/ 378282246310005 execution_time 53.396µs 53.703µs ± 0.111µs 53.725µs ± 0.065µs 53.783µs 53.849µs 53.909µs 53.976µs 0.47% -0.612 0.062 0.21% 0.008µs 1 200
credit_card/is_card_number_no_luhn/ 378282246310005 throughput 18526846.242op/s 18621099.007op/s ± 38552.558op/s 18613255.717op/s ± 22588.360op/s 18640519.558op/s 18694904.988op/s 18723064.535op/s 18727887.698op/s 0.62% 0.622 0.074 0.21% 2726.077op/s 1 200
credit_card/is_card_number_no_luhn/37828224631 execution_time 3.893µs 3.911µs ± 0.003µs 3.911µs ± 0.002µs 3.913µs 3.916µs 3.918µs 3.921µs 0.25% -0.758 7.312 0.07% 0.000µs 1 200
credit_card/is_card_number_no_luhn/37828224631 throughput 255043874.129op/s 255667859.192op/s ± 191224.075op/s 255669613.667op/s ± 120859.425op/s 255794413.718op/s 255918115.171op/s 255977472.698op/s 256879100.760op/s 0.47% 0.777 7.426 0.07% 13521.584op/s 1 200
credit_card/is_card_number_no_luhn/378282246310005 execution_time 49.852µs 50.173µs ± 0.114µs 50.169µs ± 0.078µs 50.250µs 50.357µs 50.454µs 50.526µs 0.71% 0.201 0.063 0.23% 0.008µs 1 200
credit_card/is_card_number_no_luhn/378282246310005 throughput 19791627.805op/s 19931145.350op/s ± 45098.715op/s 19932620.766op/s ± 31157.953op/s 19963630.258op/s 20001337.389op/s 20021690.543op/s 20059554.812op/s 0.64% -0.187 0.054 0.23% 3188.961op/s 1 200
credit_card/is_card_number_no_luhn/37828224631000521389798 execution_time 44.927µs 44.993µs ± 0.036µs 44.985µs ± 0.022µs 45.014µs 45.057µs 45.094µs 45.143µs 0.35% 0.866 1.071 0.08% 0.003µs 1 200
credit_card/is_card_number_no_luhn/37828224631000521389798 throughput 22151584.385op/s 22225729.939op/s ± 17716.029op/s 22229577.810op/s ± 10921.097op/s 22238205.032op/s 22249053.451op/s 22257621.800op/s 22258156.891op/s 0.13% -0.861 1.052 0.08% 1252.712op/s 1 200
credit_card/is_card_number_no_luhn/x371413321323331 execution_time 5.691µs 5.698µs ± 0.004µs 5.697µs ± 0.003µs 5.700µs 5.705µs 5.707µs 5.709µs 0.21% 0.380 -0.406 0.07% 0.000µs 1 200
credit_card/is_card_number_no_luhn/x371413321323331 throughput 175155748.891op/s 175504438.935op/s ± 121175.275op/s 175516358.126op/s ± 84651.850op/s 175593266.364op/s 175686842.962op/s 175725841.799op/s 175731332.726op/s 0.12% -0.377 -0.409 0.07% 8568.386op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
credit_card/is_card_number/ execution_time [3.911µs; 3.912µs] or [-0.012%; +0.012%] None None None
credit_card/is_card_number/ throughput [255628892.989op/s; 255687962.386op/s] or [-0.012%; +0.012%] None None None
credit_card/is_card_number/ 3782-8224-6310-005 execution_time [78.296µs; 78.421µs] or [-0.080%; +0.080%] None None None
credit_card/is_card_number/ 3782-8224-6310-005 throughput [12752131.503op/s; 12772485.843op/s] or [-0.080%; +0.080%] None None None
credit_card/is_card_number/ 378282246310005 execution_time [71.205µs; 71.289µs] or [-0.059%; +0.059%] None None None
credit_card/is_card_number/ 378282246310005 throughput [14027691.682op/s; 14044269.053op/s] or [-0.059%; +0.059%] None None None
credit_card/is_card_number/37828224631 execution_time [3.910µs; 3.911µs] or [-0.011%; +0.011%] None None None
credit_card/is_card_number/37828224631 throughput [255702309.553op/s; 255756772.617op/s] or [-0.011%; +0.011%] None None None
credit_card/is_card_number/378282246310005 execution_time [68.405µs; 68.491µs] or [-0.063%; +0.063%] None None None
credit_card/is_card_number/378282246310005 throughput [14600769.242op/s; 14619055.051op/s] or [-0.063%; +0.063%] None None None
credit_card/is_card_number/37828224631000521389798 execution_time [44.986µs; 44.998µs] or [-0.013%; +0.013%] None None None
credit_card/is_card_number/37828224631000521389798 throughput [22223436.088op/s; 22229134.502op/s] or [-0.013%; +0.013%] None None None
credit_card/is_card_number/x371413321323331 execution_time [5.697µs; 5.699µs] or [-0.010%; +0.010%] None None None
credit_card/is_card_number/x371413321323331 throughput [175481555.949op/s; 175516086.429op/s] or [-0.010%; +0.010%] None None None
credit_card/is_card_number_no_luhn/ execution_time [3.911µs; 3.912µs] or [-0.012%; +0.012%] None None None
credit_card/is_card_number_no_luhn/ throughput [255600623.382op/s; 255662255.762op/s] or [-0.012%; +0.012%] None None None
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 execution_time [64.477µs; 64.527µs] or [-0.039%; +0.039%] None None None
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 throughput [15497493.670op/s; 15509725.391op/s] or [-0.039%; +0.039%] None None None
credit_card/is_card_number_no_luhn/ 378282246310005 execution_time [53.687µs; 53.718µs] or [-0.029%; +0.029%] None None None
credit_card/is_card_number_no_luhn/ 378282246310005 throughput [18615755.994op/s; 18626442.021op/s] or [-0.029%; +0.029%] None None None
credit_card/is_card_number_no_luhn/37828224631 execution_time [3.911µs; 3.912µs] or [-0.010%; +0.010%] None None None
credit_card/is_card_number_no_luhn/37828224631 throughput [255641357.375op/s; 255694361.010op/s] or [-0.010%; +0.010%] None None None
credit_card/is_card_number_no_luhn/378282246310005 execution_time [50.157µs; 50.189µs] or [-0.031%; +0.031%] None None None
credit_card/is_card_number_no_luhn/378282246310005 throughput [19924895.102op/s; 19937395.599op/s] or [-0.031%; +0.031%] None None None
credit_card/is_card_number_no_luhn/37828224631000521389798 execution_time [44.988µs; 44.998µs] or [-0.011%; +0.011%] None None None
credit_card/is_card_number_no_luhn/37828224631000521389798 throughput [22223274.668op/s; 22228185.210op/s] or [-0.011%; +0.011%] None None None
credit_card/is_card_number_no_luhn/x371413321323331 execution_time [5.697µs; 5.698µs] or [-0.010%; +0.010%] None None None
credit_card/is_card_number_no_luhn/x371413321323331 throughput [175487645.207op/s; 175521232.662op/s] or [-0.010%; +0.010%] None None None

Group 3

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 07881eb 1758547681 gyuheon0h/prof-12581-refactor-sigpipe-test
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
redis/obfuscate_redis_string execution_time 33.544µs 33.992µs ± 0.736µs 33.656µs ± 0.058µs 33.769µs 35.498µs 35.571µs 37.480µs 11.36% 1.910 2.584 2.16% 0.052µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
redis/obfuscate_redis_string execution_time [33.890µs; 34.094µs] or [-0.300%; +0.300%] None None None

Group 4

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 07881eb 1758547681 gyuheon0h/prof-12581-refactor-sigpipe-test
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... execution_time 184.906µs 185.473µs ± 0.264µs 185.510µs ± 0.184µs 185.675µs 185.873µs 186.055µs 186.115µs 0.33% -0.148 -0.664 0.14% 0.019µs 1 200
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... throughput 5373024.221op/s 5391622.748op/s ± 7688.783op/s 5390534.451op/s ± 5343.748op/s 5397726.592op/s 5404103.419op/s 5406767.941op/s 5408152.601op/s 0.33% 0.154 -0.666 0.14% 543.679op/s 1 200
normalization/normalize_name/normalize_name/bad-name execution_time 17.880µs 17.947µs ± 0.032µs 17.944µs ± 0.017µs 17.961µs 17.994µs 18.030µs 18.154µs 1.17% 1.682 8.478 0.18% 0.002µs 1 200
normalization/normalize_name/normalize_name/bad-name throughput 55085043.901op/s 55720104.337op/s ± 97625.327op/s 55729887.079op/s ± 51450.080op/s 55775343.479op/s 55849875.558op/s 55904578.951op/s 55928069.922op/s 0.36% -1.642 8.184 0.17% 6903.153op/s 1 200
normalization/normalize_name/normalize_name/good execution_time 10.344µs 10.482µs ± 0.044µs 10.484µs ± 0.027µs 10.511µs 10.548µs 10.571µs 10.586µs 0.97% -0.420 0.237 0.42% 0.003µs 1 200
normalization/normalize_name/normalize_name/good throughput 94463170.098op/s 95398955.485op/s ± 401088.942op/s 95380168.018op/s ± 245500.965op/s 95625166.741op/s 96128294.712op/s 96489232.237op/s 96674896.239op/s 1.36% 0.446 0.274 0.42% 28361.271op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... execution_time [185.437µs; 185.510µs] or [-0.020%; +0.020%] None None None
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... throughput [5390557.157op/s; 5392688.340op/s] or [-0.020%; +0.020%] None None None
normalization/normalize_name/normalize_name/bad-name execution_time [17.943µs; 17.951µs] or [-0.024%; +0.024%] None None None
normalization/normalize_name/normalize_name/bad-name throughput [55706574.405op/s; 55733634.268op/s] or [-0.024%; +0.024%] None None None
normalization/normalize_name/normalize_name/good execution_time [10.476µs; 10.489µs] or [-0.058%; +0.058%] None None None
normalization/normalize_name/normalize_name/good throughput [95343368.415op/s; 95454542.555op/s] or [-0.058%; +0.058%] None None None

Group 5

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 07881eb 1758547681 gyuheon0h/prof-12581-refactor-sigpipe-test
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
receiver_entry_point/report/2597 execution_time 6.241ms 6.296ms ± 0.029ms 6.291ms ± 0.014ms 6.309ms 6.340ms 6.387ms 6.486ms 3.10% 2.197 10.280 0.46% 0.002ms 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
receiver_entry_point/report/2597 execution_time [6.292ms; 6.300ms] or [-0.063%; +0.063%] None None None

Group 6

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 07881eb 1758547681 gyuheon0h/prof-12581-refactor-sigpipe-test
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
two way interface execution_time 17.869µs 22.935µs ± 9.058µs 18.251µs ± 0.311µs 20.550µs 41.439µs 46.663µs 70.970µs 288.86% 1.883 3.603 39.39% 0.640µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
two way interface execution_time [21.679µs; 24.190µs] or [-5.473%; +5.473%] None None None

Group 7

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 07881eb 1758547681 gyuheon0h/prof-12581-refactor-sigpipe-test
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... execution_time 533.682µs 534.833µs ± 0.858µs 534.636µs ± 0.336µs 535.027µs 536.619µs 538.000µs 539.251µs 0.86% 2.272 6.515 0.16% 0.061µs 1 200
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... throughput 1854423.400op/s 1869747.095op/s ± 2987.344op/s 1870429.928op/s ± 1176.899op/s 1871491.298op/s 1872700.939op/s 1873384.819op/s 1873775.226op/s 0.18% -2.256 6.425 0.16% 211.237op/s 1 200
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて execution_time 381.798µs 382.613µs ± 0.299µs 382.620µs ± 0.209µs 382.777µs 383.110µs 383.289µs 383.381µs 0.20% 0.049 -0.349 0.08% 0.021µs 1 200
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて throughput 2608369.363op/s 2613609.193op/s ± 2039.505op/s 2613556.380op/s ± 1426.927op/s 2615084.010op/s 2616776.306op/s 2617470.570op/s 2619186.388op/s 0.22% -0.045 -0.349 0.08% 144.215op/s 1 200
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters execution_time 189.999µs 190.400µs ± 0.167µs 190.397µs ± 0.117µs 190.509µs 190.666µs 190.890µs 190.909µs 0.27% 0.439 0.215 0.09% 0.012µs 1 200
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters throughput 5238109.692op/s 5252109.028op/s ± 4608.515op/s 5252190.315op/s ± 3220.636op/s 5255642.716op/s 5258493.838op/s 5261287.001op/s 5263187.016op/s 0.21% -0.434 0.207 0.09% 325.871op/s 1 200
normalization/normalize_service/normalize_service/[empty string] execution_time 36.806µs 37.051µs ± 0.146µs 37.034µs ± 0.109µs 37.158µs 37.237µs 37.325µs 38.143µs 3.00% 2.141 13.762 0.39% 0.010µs 1 200
normalization/normalize_service/normalize_service/[empty string] throughput 26216940.246op/s 26990261.297op/s ± 105471.236op/s 27002486.581op/s ± 79498.981op/s 27074896.650op/s 27115870.532op/s 27143339.519op/s 27169531.001op/s 0.62% -2.014 12.547 0.39% 7457.943op/s 1 200
normalization/normalize_service/normalize_service/test_ASCII execution_time 46.000µs 46.099µs ± 0.057µs 46.091µs ± 0.030µs 46.126µs 46.201µs 46.279µs 46.374µs 0.61% 1.316 3.407 0.12% 0.004µs 1 200
normalization/normalize_service/normalize_service/test_ASCII throughput 21564013.973op/s 21692390.355op/s ± 26797.404op/s 21696060.610op/s ± 14312.701op/s 21709341.705op/s 21727357.780op/s 21737889.170op/s 21739004.412op/s 0.20% -1.303 3.345 0.12% 1894.863op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... execution_time [534.714µs; 534.952µs] or [-0.022%; +0.022%] None None None
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... throughput [1869333.078op/s; 1870161.112op/s] or [-0.022%; +0.022%] None None None
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて execution_time [382.572µs; 382.654µs] or [-0.011%; +0.011%] None None None
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて throughput [2613326.537op/s; 2613891.849op/s] or [-0.011%; +0.011%] None None None
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters execution_time [190.377µs; 190.423µs] or [-0.012%; +0.012%] None None None
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters throughput [5251470.332op/s; 5252747.724op/s] or [-0.012%; +0.012%] None None None
normalization/normalize_service/normalize_service/[empty string] execution_time [37.031µs; 37.071µs] or [-0.055%; +0.055%] None None None
normalization/normalize_service/normalize_service/[empty string] throughput [26975643.998op/s; 27004878.596op/s] or [-0.054%; +0.054%] None None None
normalization/normalize_service/normalize_service/test_ASCII execution_time [46.091µs; 46.107µs] or [-0.017%; +0.017%] None None None
normalization/normalize_service/normalize_service/test_ASCII throughput [21688676.492op/s; 21696104.217op/s] or [-0.017%; +0.017%] None None None

Group 8

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 07881eb 1758547681 gyuheon0h/prof-12581-refactor-sigpipe-test
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
benching serializing traces from their internal representation to msgpack execution_time 14.329ms 14.408ms ± 0.033ms 14.403ms ± 0.018ms 14.423ms 14.460ms 14.513ms 14.543ms 0.97% 1.177 2.515 0.23% 0.002ms 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
benching serializing traces from their internal representation to msgpack execution_time [14.403ms; 14.412ms] or [-0.032%; +0.032%] None None None

Group 9

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 07881eb 1758547681 gyuheon0h/prof-12581-refactor-sigpipe-test
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
sql/obfuscate_sql_string execution_time 88.823µs 89.007µs ± 0.238µs 88.972µs ± 0.059µs 89.052µs 89.163µs 89.296µs 92.049µs 3.46% 10.622 132.663 0.27% 0.017µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
sql/obfuscate_sql_string execution_time [88.974µs; 89.040µs] or [-0.037%; +0.037%] None None None

Group 10

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 07881eb 1758547681 gyuheon0h/prof-12581-refactor-sigpipe-test
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
concentrator/add_spans_to_concentrator execution_time 8.164ms 8.180ms ± 0.009ms 8.180ms ± 0.006ms 8.185ms 8.196ms 8.204ms 8.235ms 0.67% 1.377 5.302 0.11% 0.001ms 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
concentrator/add_spans_to_concentrator execution_time [8.179ms; 8.182ms] or [-0.016%; +0.016%] None None None

Group 11

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 07881eb 1758547681 gyuheon0h/prof-12581-refactor-sigpipe-test
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
write only interface execution_time 1.250µs 3.145µs ± 1.414µs 2.969µs ± 0.029µs 2.999µs 3.328µs 13.606µs 15.047µs 406.74% 7.535 57.289 44.87% 0.100µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
write only interface execution_time [2.949µs; 3.341µs] or [-6.234%; +6.234%] None None None

Group 12

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 07881eb 1758547681 gyuheon0h/prof-12581-refactor-sigpipe-test
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
ip_address/quantize_peer_ip_address_benchmark execution_time 4.938µs 5.011µs ± 0.041µs 5.015µs ± 0.043µs 5.037µs 5.068µs 5.071µs 5.074µs 1.19% -0.014 -1.305 0.81% 0.003µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
ip_address/quantize_peer_ip_address_benchmark execution_time [5.005µs; 5.016µs] or [-0.113%; +0.113%] None None None

Group 13

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 07881eb 1758547681 gyuheon0h/prof-12581-refactor-sigpipe-test
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_trace/test_trace execution_time 241.791ns 249.865ns ± 10.114ns 246.311ns ± 2.735ns 250.291ns 277.883ns 287.068ns 288.028ns 16.94% 2.442 5.441 4.04% 0.715ns 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_trace/test_trace execution_time [248.463ns; 251.266ns] or [-0.561%; +0.561%] None None None

Group 14

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 07881eb 1758547681 gyuheon0h/prof-12581-refactor-sigpipe-test
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
tags/replace_trace_tags execution_time 2.422µs 2.442µs ± 0.020µs 2.438µs ± 0.007µs 2.444µs 2.497µs 2.509µs 2.563µs 5.13% 2.856 9.689 0.81% 0.001µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
tags/replace_trace_tags execution_time [2.439µs; 2.445µs] or [-0.113%; +0.113%] None None None

Group 15

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 07881eb 1758547681 gyuheon0h/prof-12581-refactor-sigpipe-test
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
benching deserializing traces from msgpack to their internal representation execution_time 60.742ms 61.247ms ± 2.465ms 60.943ms ± 0.079ms 61.020ms 61.157ms 79.548ms 82.826ms 35.91% 8.006 62.565 4.01% 0.174ms 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
benching deserializing traces from msgpack to their internal representation execution_time [60.905ms; 61.589ms] or [-0.558%; +0.558%] None None None

Baseline

Omitted due to size.

@gyuheon0h gyuheon0h force-pushed the gyuheon0h/prof-12581-refactor-sigpipe-test branch from e2847e2 to cfa1296 Compare September 19, 2025 21:49
@gyuheon0h gyuheon0h changed the title Refactor sigpipe tests [Crashtracking] refactor sigpipe tests Sep 19, 2025
@gyuheon0h gyuheon0h marked this pull request as ready for review September 19, 2025 23:22
@gyuheon0h gyuheon0h requested a review from a team as a code owner September 19, 2025 23:22
@gyuheon0h gyuheon0h force-pushed the gyuheon0h/prof-12581-refactor-sigpipe-test branch from 6a49427 to 6e8239f Compare September 22, 2025 19:18
@gyuheon0h gyuheon0h requested review from danielsn and ekump September 22, 2025 19:21
Copy link
Contributor

@ekump ekump left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, FWIW

@gyuheon0h
Copy link
Contributor Author

/merge

@dd-devflow-routing-codex
Copy link

dd-devflow-routing-codex bot commented Sep 22, 2025

View all feedbacks in Devflow UI.

2025-09-22 20:49:22 UTC ℹ️ Start processing command /merge


2025-09-22 20:49:27 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in main is approximately 46m (p90).


2025-09-22 21:20:00 UTC ℹ️ MergeQueue: This merge request was merged

@dd-mergequeue dd-mergequeue bot merged commit e3bc25c into main Sep 22, 2025
46 of 48 checks passed
@dd-mergequeue dd-mergequeue bot deleted the gyuheon0h/prof-12581-refactor-sigpipe-test branch September 22, 2025 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants