-
Notifications
You must be signed in to change notification settings - Fork 15
Implement with_endpoint for SendData
#1139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1139 +/- ##
==========================================
+ Coverage 71.27% 71.29% +0.01%
==========================================
Files 343 343
Lines 52396 52471 +75
==========================================
+ Hits 37347 37410 +63
- Misses 15049 15061 +12
🚀 New features to boost your workflow:
|
BenchmarksComparisonBenchmark execution time: 2025-07-11 14:40:27 Comparing candidate commit 27aef15 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 52 metrics, 2 unstable metrics. CandidateCandidate benchmark detailsGroup 1
Group 2
Group 3
Group 4
Group 5
Group 6
Group 7
Group 8
Group 9
Group 10
Group 11
Group 12
Group 13
BaselineOmitted due to size. |
| } | ||
|
|
||
| /// Overrides the set target Endpoint. | ||
| /// Returns a copy of the SendData with the user-defined endpoint. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: Clone and Copy are different.
| /// Returns a copy of the SendData with the user-defined endpoint. | |
| /// Returns a clone of the SendData with the user-defined endpoint. |
Artifact Size Benchmark Reportaarch64-alpine-linux-musl
aarch64-unknown-linux-gnu
libdatadog-x64-windows
libdatadog-x86-windows
x86_64-alpine-linux-musl
x86_64-unknown-linux-gnu
|
Adds support for dual shipping traces to endpoints configured using the `apm_config` YAML or `DD_APM_CONFIG_ADDITIONAL_ENDPOINTS` env var config. #### Additional Notes: - Bumped libdatadog (and serverless-components) to include DataDog/libdatadog#1139 - Adds configuration option to set compression level for trace payloads
What does this PR do?
Implements a function
with_endpointforSendDatathat returns a copy of theSendDatausing the user-defined endpoint.Motivation
Supporting dual shipping for traces in the Lambda Extension - need to be able to make a copy of the original traces
SendDataand send it to another endpoint.Additional Notes
Anything else we should know when reviewing?
How to test the change?
Describe here in detail how the change can be validated.