Skip to content

Conversation

eric-weaver
Copy link
Contributor

What does this PR do?

The goal of this change is to cleanup errors captured on explain plan events so that they are more clear for users. We now capture exception messages properly. When the error explaining is due to a permission error or missing explain procedure we'll now have a unique error marker which will allow us to surface a clearer message in the DBM UI. We'll still fallback to the old explain plan error view for connection or other errors

Currently explain plan errors will show like this
Screenshot 2025-10-17 at 5 54 51 PM

Screenshot 2025-10-17 at 5 55 29 PM

After this change it will look like this
Screenshot 2025-10-17 at 5 56 23 PM

Screenshot 2025-10-17 at 5 56 42 PM

Motivation

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Add the qa/skip-qa label if the PR doesn't need to be tested during QA.
  • If you need to backport this PR to another branch, you can add the backport/<branch-name> label to the PR and it will automatically open a backport PR once this one is merged

@codecov
Copy link

codecov bot commented Oct 17, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.12%. Comparing base (497be69) to head (57a0b00).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

sethsamuel
sethsamuel previously approved these changes Oct 20, 2025
@temporal-github-worker-1 temporal-github-worker-1 bot dismissed sethsamuel’s stale review October 20, 2025 14:43

Review from sethsamuel is dismissed. Related teams and files:

  • database-monitoring-agent
    • mysql/changelog.d/21693.fixed
@eric-weaver eric-weaver added this pull request to the merge queue Oct 21, 2025
Merged via the queue into master with commit 610332b Oct 21, 2025
48 checks passed
@eric-weaver eric-weaver deleted the eric.weaver/DBMON-5793 branch October 21, 2025 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants