[DBMON-5793] Fix mysql explain plan error reporting #21693
Merged
+22
−5
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The goal of this change is to cleanup errors captured on explain plan events so that they are more clear for users. We now capture exception messages properly. When the error explaining is due to a permission error or missing explain procedure we'll now have a unique error marker which will allow us to surface a clearer message in the DBM UI. We'll still fallback to the old explain plan error view for connection or other errors
Currently explain plan errors will show like this

After this change it will look like this

Motivation
Review checklist (to be filled by reviewers)
qa/skip-qa
label if the PR doesn't need to be tested during QA.backport/<branch-name>
label to the PR and it will automatically open a backport PR once this one is merged