Skip to content

Conversation

ricmatsui
Copy link
Contributor

@ricmatsui ricmatsui commented Oct 12, 2025

What does this PR do?

Adds a new metric for the GlusterFS integration to monitor the number of entries requiring healing in a volume by parsing additional output from gstatus.

Motivation

Currently the integration is missing a way to monitor if replicated volumes are failing to self-heal.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Add the qa/skip-qa label if the PR doesn't need to be tested during QA.
  • If you need to backport this PR to another branch, you can add the backport/<branch-name> label to the PR and it will automatically open a backport PR once this one is merged

@ricmatsui ricmatsui force-pushed the glusterfs-volume-heal branch from 6b5ef11 to d8904d5 Compare October 12, 2025 06:20
@codecov
Copy link

codecov bot commented Oct 12, 2025

Codecov Report

❌ Patch coverage is 92.85714% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 88.99%. Comparing base (026cb75) to head (61fad41).
⚠️ Report is 56 commits behind head on master.

Additional details and impacted files
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@AAraKKe AAraKKe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for the PR! Looks good from my side.

I just have a couple of suggestions. Since I am not 100% sure of how often this can vary, let me know what do you think in the comments below and we can decide how to move forward.

My Feedback Legend

Here's a quick guide to the prefixes I use in my comments:

praise: no action needed, just celebrate!
question: I need clarification or I'm seeking to understand your approach.
suggestion: I'm proposing an improvement. This is optional but recommended.
nit: A minor, non-blocking issue (e.g., style, typo). Feel free to ignore.
request: A change I believe is necessary before this can be merged.

The only blocking comments are request, any other type of comment can be applied at discretion of the developer.

@ricmatsui ricmatsui requested a review from AAraKKe October 21, 2025 03:27
@AAraKKe AAraKKe added this pull request to the merge queue Oct 21, 2025
Merged via the queue into DataDog:master with commit 35110b0 Oct 21, 2025
59 of 60 checks passed
@ricmatsui ricmatsui deleted the glusterfs-volume-heal branch October 21, 2025 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants