Skip to content

Conversation

@github-actions
Copy link
Contributor

@github-actions github-actions bot commented Nov 15, 2024

Backport ecd0ab1 from #11353 to 2.17.

Span pointer issues should be debug messages rather than warnings since they are not really actionable from the perspective of our users.

We'd also like to have some instrumentation telemetry to see how the logic is doing.

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

@datadog-dd-trace-py-rkomorn
Copy link

datadog-dd-trace-py-rkomorn bot commented Nov 15, 2024

Datadog Report

Branch report: backport-11353-to-2.17
Commit report: 7201ee4
Test service: dd-trace-py

✅ 0 Failed, 605 Passed, 681 Skipped, 19m 58.54s Total duration (16m 35.06s time saved)

@pr-commenter
Copy link

pr-commenter bot commented Nov 15, 2024

Benchmarks

Benchmark execution time: 2024-11-18 16:40:03

Comparing candidate commit 7201ee4 in PR branch backport-11353-to-2.17 with baseline commit 4271b53 in branch 2.17.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 202 metrics, 2 unstable metrics.

@apiarian-datadog
Copy link
Contributor

closing and reopening to unblock the pipelines

@github-actions
Copy link
Contributor Author

CODEOWNERS have been resolved as:

ddtrace/_trace/telemetry.py                                             @DataDog/apm-sdk-api-python
ddtrace/_trace/utils_botocore/span_pointers/telemetry.py                @DataDog/apm-sdk-api-python
releasenotes/notes/reduce-span-pointer-noise-e1cf01ec581a409c.yaml      @DataDog/apm-python
tests/tracer/test_telemetry.py                                          @DataDog/apm-sdk-api-python
ddtrace/_trace/_span_pointer.py                                         @DataDog/apm-sdk-api-python
ddtrace/_trace/utils_botocore/span_pointers/__init__.py                 @DataDog/apm-sdk-api-python
ddtrace/_trace/utils_botocore/span_pointers/dynamodb.py                 @DataDog/apm-sdk-api-python
ddtrace/_trace/utils_botocore/span_pointers/s3.py                       @DataDog/apm-sdk-api-python
tests/tracer/utils_botocore/test_span_pointers.py                       @DataDog/apm-sdk-api-python

Span pointer issues should be debug messages rather than warnings since
they are not really actionable from the perspective of our users.

We'd also like to have some instrumentation telemetry to see how the
logic is doing.

## Checklist
- [x] PR author has checked that all the criteria below are met
- The PR description includes an overview of the change
- The PR description articulates the motivation for the change
- The change includes tests OR the PR description describes a testing
strategy
- The PR description notes risks associated with the change, if any
- Newly-added code is easy to change
- The change follows the [library release note
guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html)
- The change includes or references documentation updates if necessary
- Backport labels are set (if
[applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting))

## Reviewer Checklist
- [x] Reviewer has checked that all the criteria below are met
- Title is accurate
- All changes are related to the pull request's stated goal
- Avoids breaking
[API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces)
changes
- Testing strategy adequately addresses listed risks
- Newly-added code is easy to change
- Release note makes sense to a user of the library
- If necessary, author has acknowledged and discussed the performance
implications of this PR as reported in the benchmarks PR comment
- Backport labels are set in a manner that is consistent with the
[release branch maintenance
policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)

(cherry picked from commit ecd0ab1)
@apiarian-datadog apiarian-datadog merged commit 7ec8701 into 2.17 Nov 18, 2024
543 checks passed
@apiarian-datadog apiarian-datadog deleted the backport-11353-to-2.17 branch November 18, 2024 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants