Skip to content

Retry open connection on lettuce 5 tests #8145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 3, 2025
Merged

Retry open connection on lettuce 5 tests #8145

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions dd-java-agent/instrumentation/lettuce-5/src/test/groovy/Lettuce5ReactiveClientTest.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,13 +8,14 @@ import datadog.trace.api.DDSpanTypes
import datadog.trace.bootstrap.instrumentation.api.Tags
import io.lettuce.core.ClientOptions
import io.lettuce.core.RedisClient
import io.lettuce.core.api.StatefulConnection
import io.lettuce.core.api.StatefulRedisConnection
import io.lettuce.core.api.reactive.RedisReactiveCommands
import io.lettuce.core.api.sync.RedisCommands
import org.testcontainers.containers.wait.strategy.Wait
import reactor.core.scheduler.Schedulers
import spock.lang.Shared
import spock.util.concurrent.AsyncConditions
import spock.util.concurrent.PollingConditions

import java.util.function.Consumer

Expand All @@ -40,7 +41,7 @@ abstract class Lettuce5ReactiveClientTest extends VersionedNamingTestBase {
.waitingFor(Wait.forListeningPort())

RedisClient redisClient
StatefulConnection connection
StatefulRedisConnection connection
RedisReactiveCommands<String, ?> reactiveCommands
RedisCommands<String, ?> syncCommands

Expand All @@ -54,7 +55,9 @@ abstract class Lettuce5ReactiveClientTest extends VersionedNamingTestBase {

redisClient.setOptions(CLIENT_OPTIONS)

connection = redisClient.connect()
new PollingConditions(delay: 3, timeout: 15).eventually {
(connection = redisClient.connect()) != null
}
reactiveCommands = connection.reactive()
syncCommands = connection.sync()

Expand Down
Loading