Skip to content

Improve exception handling in full mode for SQL Server #7411

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 12, 2024
Merged

Improve exception handling in full mode for SQL Server #7411

merged 2 commits into from
Aug 12, 2024

Conversation

@nenadnoveljic
Copy link
Member

@nenadnoveljic nenadnoveljic commented Aug 12, 2024

What Does This Do

Improve the readability by localizing exception handling.

Motivation

Additional Notes

Following @dougqh 's recommendation.

Contributor Checklist

Jira ticket: [PROJ-IDENT]

@nenadnoveljic nenadnoveljic self-assigned this Aug 12, 2024
@nenadnoveljic nenadnoveljic requested a review from a team as a code owner August 12, 2024 09:22
@pr-commenter
Copy link

pr-commenter bot commented Aug 12, 2024 •
edited
Loading

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master nenadnoveljic/sqlserver-improve-exception-handling
git_commit_date 1723447864 1723453192
git_commit_sha 0e0a715 88369e8
release_version 1.39.0-SNAPSHOT~0e0a715784 1.39.0-SNAPSHOT~88369e8987
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1723456800 1723456800
ci_job_id 601415996 601415996
ci_pipeline_id 41447406 41447406
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
module Agent Agent
parent None None
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 47 metrics, 16 unstable metrics.

Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.39.0-SNAPSHOT~88369e8987, baseline=1.39.0-SNAPSHOT~0e0a715784

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.062 s) : 0, 1061781
Total [baseline] (10.352 s) : 0, 10351558
Agent [candidate] (1.047 s) : 0, 1046857
Total [candidate] (10.394 s) : 0, 10394339
section appsec
Agent [baseline] (1.168 s) : 0, 1168458
Total [baseline] (10.563 s) : 0, 10562687
Agent [candidate] (1.173 s) : 0, 1173476
Total [candidate] (10.518 s) : 0, 10517585
section iast
Agent [baseline] (1.18 s) : 0, 1180079
Total [baseline] (10.873 s) : 0, 10873399
Agent [candidate] (1.192 s) : 0, 1192347
Total [candidate] (10.814 s) : 0, 10814115
section profiling
Agent [baseline] (1.256 s) : 0, 1255843
Total [baseline] (10.729 s) : 0, 10729336
Agent [candidate] (1.248 s) : 0, 1248123
Total [candidate] (10.656 s) : 0, 10655639
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.062 s -
Agent appsec 1.168 s 106.677 ms (10.0%)
Agent iast 1.18 s 118.298 ms (11.1%)
Agent profiling 1.256 s 194.062 ms (18.3%)
Total tracing 10.352 s -
Total appsec 10.563 s 211.129 ms (2.0%)
Total iast 10.873 s 521.84 ms (5.0%)
Total profiling 10.729 s 377.777 ms (3.6%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.047 s -
Agent appsec 1.173 s 126.618 ms (12.1%)
Agent iast 1.192 s 145.49 ms (13.9%)
Agent profiling 1.248 s 201.266 ms (19.2%)
Total tracing 10.394 s -
Total appsec 10.518 s 123.247 ms (1.2%)
Total iast 10.814 s 419.776 ms (4.0%)
Total profiling 10.656 s 261.3 ms (2.5%) 
gantt
    title petclinic - break down per module: candidate=1.39.0-SNAPSHOT~88369e8987, baseline=1.39.0-SNAPSHOT~0e0a715784

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (677.174 ms) : 0, 677174
BytebuddyAgent [candidate] (667.344 ms) : 0, 667344
GlobalTracer [baseline] (310.719 ms) : 0, 310719
GlobalTracer [candidate] (306.771 ms) : 0, 306771
AppSec [baseline] (51.926 ms) : 0, 51926
AppSec [candidate] (51.072 ms) : 0, 51072
Remote Config [baseline] (695.36 µs) : 0, 695
Remote Config [candidate] (685.231 µs) : 0, 685
Telemetry [baseline] (7.688 ms) : 0, 7688
Telemetry [candidate] (7.52 ms) : 0, 7520
section appsec
BytebuddyAgent [baseline] (677.627 ms) : 0, 677627
BytebuddyAgent [candidate] (680.546 ms) : 0, 680546
GlobalTracer [baseline] (299.965 ms) : 0, 299965
GlobalTracer [candidate] (301.553 ms) : 0, 301553
AppSec [baseline] (156.638 ms) : 0, 156638
AppSec [candidate] (157.093 ms) : 0, 157093
Remote Config [baseline] (603.35 µs) : 0, 603
Remote Config [candidate] (606.173 µs) : 0, 606
Telemetry [baseline] (9.69 ms) : 0, 9690
Telemetry [candidate] (9.949 ms) : 0, 9949
IAST [baseline] (20.911 ms) : 0, 20911
IAST [candidate] (20.338 ms) : 0, 20338
section iast
BytebuddyAgent [baseline] (784.396 ms) : 0, 784396
BytebuddyAgent [candidate] (793.729 ms) : 0, 793729
GlobalTracer [baseline] (297.643 ms) : 0, 297643
GlobalTracer [candidate] (300.755 ms) : 0, 300755
AppSec [baseline] (52.554 ms) : 0, 52554
AppSec [candidate] (52.889 ms) : 0, 52889
Remote Config [baseline] (581.964 µs) : 0, 582
Remote Config [candidate] (586.735 µs) : 0, 587
Telemetry [baseline] (8.718 ms) : 0, 8718
Telemetry [candidate] (8.816 ms) : 0, 8816
IAST [baseline] (22.672 ms) : 0, 22672
IAST [candidate] (21.91 ms) : 0, 21910
section profiling
ProfilingAgent [baseline] (95.868 ms) : 0, 95868
ProfilingAgent [candidate] (94.753 ms) : 0, 94753
BytebuddyAgent [baseline] (668.752 ms) : 0, 668752
BytebuddyAgent [candidate] (663.771 ms) : 0, 663771
GlobalTracer [baseline] (392.484 ms) : 0, 392484
GlobalTracer [candidate] (391.423 ms) : 0, 391423
AppSec [baseline] (53.079 ms) : 0, 53079
AppSec [candidate] (52.89 ms) : 0, 52890
Remote Config [baseline] (680.723 µs) : 0, 681
Remote Config [candidate] (693.374 µs) : 0, 693
Telemetry [baseline] (7.423 ms) : 0, 7423
Telemetry [candidate] (7.386 ms) : 0, 7386
Profiling [baseline] (95.893 ms) : 0, 95893
Profiling [candidate] (94.778 ms) : 0, 94778
Loading
Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.39.0-SNAPSHOT~88369e8987, baseline=1.39.0-SNAPSHOT~0e0a715784

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.055 s) : 0, 1054954
Total [baseline] (8.511 s) : 0, 8511002
Agent [candidate] (1.054 s) : 0, 1053957
Total [candidate] (8.531 s) : 0, 8530611
section iast
Agent [baseline] (1.176 s) : 0, 1175881
Total [baseline] (8.99 s) : 0, 8990270
Agent [candidate] (1.177 s) : 0, 1176682
Total [candidate] (9.03 s) : 0, 9029927
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.179 s) : 0, 1179205
Total [baseline] (8.992 s) : 0, 8992133
Agent [candidate] (1.18 s) : 0, 1179939
Total [candidate] (8.991 s) : 0, 8990788
section iast_TELEMETRY_OFF
Agent [baseline] (1.175 s) : 0, 1175306
Total [baseline] (8.997 s) : 0, 8996758
Agent [candidate] (1.185 s) : 0, 1185389
Total [candidate] (9.01 s) : 0, 9009725
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.055 s -
Agent iast 1.176 s 120.928 ms (11.5%)
Agent iast_HARDCODED_SECRET_DISABLED 1.179 s 124.251 ms (11.8%)
Agent iast_TELEMETRY_OFF 1.175 s 120.352 ms (11.4%)
Total tracing 8.511 s -
Total iast 8.99 s 479.268 ms (5.6%)
Total iast_HARDCODED_SECRET_DISABLED 8.992 s 481.13 ms (5.7%)
Total iast_TELEMETRY_OFF 8.997 s 485.755 ms (5.7%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.054 s -
Agent iast 1.177 s 122.725 ms (11.6%)
Agent iast_HARDCODED_SECRET_DISABLED 1.18 s 125.982 ms (12.0%)
Agent iast_TELEMETRY_OFF 1.185 s 131.432 ms (12.5%)
Total tracing 8.531 s -
Total iast 9.03 s 499.316 ms (5.9%)
Total iast_HARDCODED_SECRET_DISABLED 8.991 s 460.177 ms (5.4%)
Total iast_TELEMETRY_OFF 9.01 s 479.114 ms (5.6%) 
gantt
    title insecure-bank - break down per module: candidate=1.39.0-SNAPSHOT~88369e8987, baseline=1.39.0-SNAPSHOT~0e0a715784

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (672.929 ms) : 0, 672929
BytebuddyAgent [candidate] (671.958 ms) : 0, 671958
GlobalTracer [baseline] (308.892 ms) : 0, 308892
GlobalTracer [candidate] (308.752 ms) : 0, 308752
AppSec [baseline] (51.347 ms) : 0, 51347
AppSec [candidate] (51.406 ms) : 0, 51406
Remote Config [baseline] (701.42 µs) : 0, 701
Remote Config [candidate] (696.608 µs) : 0, 697
Telemetry [baseline] (7.582 ms) : 0, 7582
Telemetry [candidate] (7.603 ms) : 0, 7603
section iast
BytebuddyAgent [baseline] (782.18 ms) : 0, 782180
BytebuddyAgent [candidate] (782.31 ms) : 0, 782310
GlobalTracer [baseline] (296.425 ms) : 0, 296425
GlobalTracer [candidate] (296.632 ms) : 0, 296632
AppSec [baseline] (53.302 ms) : 0, 53302
AppSec [candidate] (51.526 ms) : 0, 51526
IAST [baseline] (22.896 ms) : 0, 22896
IAST [candidate] (20.991 ms) : 0, 20991
Remote Config [baseline] (571.355 µs) : 0, 571
Remote Config [candidate] (583.936 µs) : 0, 584
Telemetry [baseline] (7.047 ms) : 0, 7047
Telemetry [candidate] (11.131 ms) : 0, 11131
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (783.975 ms) : 0, 783975
BytebuddyAgent [candidate] (784.412 ms) : 0, 784412
GlobalTracer [baseline] (297.895 ms) : 0, 297895
GlobalTracer [candidate] (297.519 ms) : 0, 297519
AppSec [baseline] (50.381 ms) : 0, 50381
AppSec [candidate] (49.817 ms) : 0, 49817
IAST [baseline] (24.732 ms) : 0, 24732
IAST [candidate] (26.879 ms) : 0, 26879
Remote Config [baseline] (583.988 µs) : 0, 584
Remote Config [candidate] (578.061 µs) : 0, 578
Telemetry [baseline] (8.094 ms) : 0, 8094
Telemetry [candidate] (7.166 ms) : 0, 7166
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (780.679 ms) : 0, 780679
BytebuddyAgent [candidate] (787.931 ms) : 0, 787931
GlobalTracer [baseline] (297.375 ms) : 0, 297375
GlobalTracer [candidate] (299.739 ms) : 0, 299739
AppSec [baseline] (53.132 ms) : 0, 53132
AppSec [candidate] (51.81 ms) : 0, 51810
IAST [baseline] (22.974 ms) : 0, 22974
IAST [candidate] (24.559 ms) : 0, 24559
Remote Config [baseline] (615.607 µs) : 0, 616
Remote Config [candidate] (616.035 µs) : 0, 616
Telemetry [baseline] (7.029 ms) : 0, 7029
Telemetry [candidate] (7.084 ms) : 0, 7084
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
end_time 2024-08-12T09:30:41 2024-08-12T09:37:30
git_branch master nenadnoveljic/sqlserver-improve-exception-handling
git_commit_date 1723447864 1723453192
git_commit_sha 0e0a715 88369e8
release_version 1.39.0-SNAPSHOT~0e0a715784 1.39.0-SNAPSHOT~88369e8987
start_time 2024-08-12T09:30:27 2024-08-12T09:37:17
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1723455795 1723455795
ci_job_id 601415997 601415997
ci_pipeline_id 41447406 41447406
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 17 unstable metrics.

Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.39.0-SNAPSHOT~88369e8987, baseline=1.39.0-SNAPSHOT~0e0a715784
    dateFormat X
    axisFormat %s
section baseline
no_agent (367.888 µs) : 349, 387
.   : milestone, 368,
iast (486.151 µs) : 465, 508
.   : milestone, 486,
iast_FULL (555.417 µs) : 533, 577
.   : milestone, 555,
iast_GLOBAL (512.282 µs) : 490, 535
.   : milestone, 512,
iast_HARDCODED_SECRET_DISABLED (484.801 µs) : 463, 507
.   : milestone, 485,
iast_INACTIVE (454.971 µs) : 432, 477
.   : milestone, 455,
iast_TELEMETRY_OFF (471.136 µs) : 450, 492
.   : milestone, 471,
tracing (442.284 µs) : 422, 463
.   : milestone, 442,
section candidate
no_agent (376.214 µs) : 356, 396
.   : milestone, 376,
iast (487.352 µs) : 466, 509
.   : milestone, 487,
iast_FULL (556.355 µs) : 534, 579
.   : milestone, 556,
iast_GLOBAL (508.84 µs) : 486, 531
.   : milestone, 509,
iast_HARDCODED_SECRET_DISABLED (489.534 µs) : 468, 511
.   : milestone, 490,
iast_INACTIVE (458.338 µs) : 435, 481
.   : milestone, 458,
iast_TELEMETRY_OFF (473.389 µs) : 452, 495
.   : milestone, 473,
tracing (442.643 µs) : 422, 463
.   : milestone, 443,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 367.888 µs [348.57 µs, 387.205 µs] -
iast 486.151 µs [464.661 µs, 507.641 µs] 118.263 µs (32.1%)
iast_FULL 555.417 µs [533.338 µs, 577.496 µs] 187.529 µs (51.0%)
iast_GLOBAL 512.282 µs [489.684 µs, 534.88 µs] 144.395 µs (39.2%)
iast_HARDCODED_SECRET_DISABLED 484.801 µs [462.842 µs, 506.76 µs] 116.913 µs (31.8%)
iast_INACTIVE 454.971 µs [432.482 µs, 477.459 µs] 87.083 µs (23.7%)
iast_TELEMETRY_OFF 471.136 µs [450.024 µs, 492.248 µs] 103.248 µs (28.1%)
tracing 442.284 µs [421.679 µs, 462.89 µs] 74.397 µs (20.2%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 376.214 µs [356.07 µs, 396.359 µs] -
iast 487.352 µs [465.564 µs, 509.14 µs] 111.138 µs (29.5%)
iast_FULL 556.355 µs [533.798 µs, 578.911 µs] 180.14 µs (47.9%)
iast_GLOBAL 508.84 µs [486.344 µs, 531.336 µs] 132.626 µs (35.3%)
iast_HARDCODED_SECRET_DISABLED 489.534 µs [467.904 µs, 511.163 µs] 113.319 µs (30.1%)
iast_INACTIVE 458.338 µs [435.19 µs, 481.487 µs] 82.124 µs (21.8%)
iast_TELEMETRY_OFF 473.389 µs [451.946 µs, 494.832 µs] 97.175 µs (25.8%)
tracing 442.643 µs [421.996 µs, 463.29 µs] 66.429 µs (17.7%)
Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.39.0-SNAPSHOT~88369e8987, baseline=1.39.0-SNAPSHOT~0e0a715784
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.35 ms) : 1330, 1369
.   : milestone, 1350,
appsec (1.706 ms) : 1682, 1731
.   : milestone, 1706,
appsec_no_iast (1.702 ms) : 1677, 1727
.   : milestone, 1702,
iast (1.491 ms) : 1468, 1514
.   : milestone, 1491,
profiling (1.487 ms) : 1462, 1511
.   : milestone, 1487,
tracing (1.481 ms) : 1457, 1505
.   : milestone, 1481,
section candidate
no_agent (1.36 ms) : 1341, 1379
.   : milestone, 1360,
appsec (1.712 ms) : 1688, 1737
.   : milestone, 1712,
appsec_no_iast (1.731 ms) : 1707, 1754
.   : milestone, 1731,
iast (1.482 ms) : 1459, 1505
.   : milestone, 1482,
profiling (1.489 ms) : 1465, 1513
.   : milestone, 1489,
tracing (1.459 ms) : 1434, 1484
.   : milestone, 1459,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.35 ms [1.33 ms, 1.369 ms] -
appsec 1.706 ms [1.682 ms, 1.731 ms] 356.668 µs (26.4%)
appsec_no_iast 1.702 ms [1.677 ms, 1.727 ms] 352.608 µs (26.1%)
iast 1.491 ms [1.468 ms, 1.514 ms] 141.346 µs (10.5%)
profiling 1.487 ms [1.462 ms, 1.511 ms] 136.923 µs (10.1%)
tracing 1.481 ms [1.457 ms, 1.505 ms] 131.313 µs (9.7%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.36 ms [1.341 ms, 1.379 ms] -
appsec 1.712 ms [1.688 ms, 1.737 ms] 352.368 µs (25.9%)
appsec_no_iast 1.731 ms [1.707 ms, 1.754 ms] 370.904 µs (27.3%)
iast 1.482 ms [1.459 ms, 1.505 ms] 121.901 µs (9.0%)
profiling 1.489 ms [1.465 ms, 1.513 ms] 129.237 µs (9.5%)
tracing 1.459 ms [1.434 ms, 1.484 ms] 98.664 µs (7.3%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master nenadnoveljic/sqlserver-improve-exception-handling
git_commit_date 1723447864 1723453192
git_commit_sha 0e0a715 88369e8
release_version 1.39.0-SNAPSHOT~0e0a715784 1.39.0-SNAPSHOT~88369e8987
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1723456317 1723456317
ci_job_id 601415998 601415998
ci_pipeline_id 41447406 41447406
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant appsec appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

Execution time for tomcat 
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.39.0-SNAPSHOT~88369e8987, baseline=1.39.0-SNAPSHOT~0e0a715784
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.461 ms) : 1449, 1472
.   : milestone, 1461,
appsec (2.227 ms) : 2192, 2263
.   : milestone, 2227,
iast (1.972 ms) : 1930, 2014
.   : milestone, 1972,
iast_GLOBAL (2.006 ms) : 1963, 2049
.   : milestone, 2006,
profiling (1.862 ms) : 1827, 1897
.   : milestone, 1862,
tracing (1.83 ms) : 1798, 1862
.   : milestone, 1830,
section candidate
no_agent (1.456 ms) : 1445, 1467
.   : milestone, 1456,
appsec (2.215 ms) : 2180, 2250
.   : milestone, 2215,
iast (1.97 ms) : 1928, 2013
.   : milestone, 1970,
iast_GLOBAL (2.015 ms) : 1973, 2058
.   : milestone, 2015,
profiling (1.856 ms) : 1821, 1892
.   : milestone, 1856,
tracing (1.837 ms) : 1804, 1870
.   : milestone, 1837,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.461 ms [1.449 ms, 1.472 ms] -
appsec 2.227 ms [2.192 ms, 2.263 ms] 766.531 µs (52.5%)
iast 1.972 ms [1.93 ms, 2.014 ms] 511.666 µs (35.0%)
iast_GLOBAL 2.006 ms [1.963 ms, 2.049 ms] 545.465 µs (37.3%)
profiling 1.862 ms [1.827 ms, 1.897 ms] 401.231 µs (27.5%)
tracing 1.83 ms [1.798 ms, 1.862 ms] 369.659 µs (25.3%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.456 ms [1.445 ms, 1.467 ms] -
appsec 2.215 ms [2.18 ms, 2.25 ms] 758.654 µs (52.1%)
iast 1.97 ms [1.928 ms, 2.013 ms] 514.231 µs (35.3%)
iast_GLOBAL 2.015 ms [1.973 ms, 2.058 ms] 559.058 µs (38.4%)
profiling 1.856 ms [1.821 ms, 1.892 ms] 400.194 µs (27.5%)
tracing 1.837 ms [1.804 ms, 1.87 ms] 380.788 µs (26.2%)
Execution time for biojava 
gantt
    title biojava - execution time [CI 0.99] : candidate=1.39.0-SNAPSHOT~88369e8987, baseline=1.39.0-SNAPSHOT~0e0a715784
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.024 s) : 15024000, 15024000
.   : milestone, 15024000,
appsec (14.889 s) : 14889000, 14889000
.   : milestone, 14889000,
iast (18.889 s) : 18889000, 18889000
.   : milestone, 18889000,
iast_GLOBAL (17.849 s) : 17849000, 17849000
.   : milestone, 17849000,
profiling (15.681 s) : 15681000, 15681000
.   : milestone, 15681000,
tracing (14.929 s) : 14929000, 14929000
.   : milestone, 14929000,
section candidate
no_agent (15.04 s) : 15040000, 15040000
.   : milestone, 15040000,
appsec (15.109 s) : 15109000, 15109000
.   : milestone, 15109000,
iast (19.051 s) : 19051000, 19051000
.   : milestone, 19051000,
iast_GLOBAL (18.007 s) : 18007000, 18007000
.   : milestone, 18007000,
profiling (15.313 s) : 15313000, 15313000
.   : milestone, 15313000,
tracing (15.164 s) : 15164000, 15164000
.   : milestone, 15164000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.024 s [15.024 s, 15.024 s] -
appsec 14.889 s [14.889 s, 14.889 s] -135.0 ms (-0.9%)
iast 18.889 s [18.889 s, 18.889 s] 3.865 s (25.7%)
iast_GLOBAL 17.849 s [17.849 s, 17.849 s] 2.825 s (18.8%)
profiling 15.681 s [15.681 s, 15.681 s] 657.0 ms (4.4%)
tracing 14.929 s [14.929 s, 14.929 s] -95.0 ms (-0.6%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.04 s [15.04 s, 15.04 s] -
appsec 15.109 s [15.109 s, 15.109 s] 69.0 ms (0.5%)
iast 19.051 s [19.051 s, 19.051 s] 4.011 s (26.7%)
iast_GLOBAL 18.007 s [18.007 s, 18.007 s] 2.967 s (19.7%)
profiling 15.313 s [15.313 s, 15.313 s] 273.0 ms (1.8%)
tracing 15.164 s [15.164 s, 15.164 s] 124.0 ms (0.8%)

@nenadnoveljic nenadnoveljic changed the title Nenadnoveljic/sqlserver improve exception handling Improve exception handling in full mode for SQL Server Aug 12, 2024
@PerfectSlayer PerfectSlayer added tag: no release notes Changes to exclude from release notes inst: jdbc JDBC instrumentation type: refactoring labels Aug 12, 2024
@nenadnoveljic nenadnoveljic merged commit 93ecbc6 into master Aug 12, 2024
@nenadnoveljic nenadnoveljic deleted the nenadnoveljic/sqlserver-improve-exception-handling branch August 12, 2024 10:12
@github-actions github-actions bot added this to the 1.39.0 milestone Aug 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@PerfectSlayer PerfectSlayer PerfectSlayer approved these changes

Assignees

@nenadnoveljic nenadnoveljic

Labels

inst: jdbc JDBC instrumentation tag: no release notes Changes to exclude from release notes type: refactoring

Projects

None yet

Milestone

1.39.0

Development

Successfully merging this pull request may close these issues.

3 participants

@nenadnoveljic @PerfectSlayer