Generator NG #714
Merged
Generator NG #714
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
therve
reviewed
Jan 31, 2022
Contributor
therve
left a comment
therve
left a comment
There was a problem hiding this comment.
Looks really nice! Only spotting some small issues like nullable, and constraints check missing. It'd be nice to remove docs and spec in a different PR to reduce the diff (Chrome is dying as I speak).
We need to think about a solution for docs like rdoc or yard.
jirikuncar
force-pushed
the
jirikuncar/generator-ng
branch
from
83fe08b to
8ceb351
Compare
jirikuncar
force-pushed
the
jirikuncar/generator-ng
branch
from
8ceb351 to
9e36101
Compare
therve
approved these changes
Feb 7, 2022
therve
reviewed
Feb 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Port to Jinja2