-
Notifications
You must be signed in to change notification settings - Fork 162
🐛 [RUM-11848] Block Logs initialization on Node environments #3914
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Bundles Sizes Evolution
🚀 CPU Performance
🧠 Memory Performance
|
|
36e6e4d to
9acd9dc
Compare
|
/to-staging |
1 similar comment
|
/to-staging |
|
View all feedbacks in Devflow UI.
Commit 26e2c93cad will soon be integrated into staging-43.
Commit 26e2c93cad has been merged into staging-43 in merge commit ec3c412e7d. Check out the triggered pipeline on Gitlab 🦊 If you need to revert this integration, you can use the following command: |
Integrated commit sha: 26e2c93 Co-authored-by: mormubis <[email protected]>
|
/code revert-integration |
|
View all feedbacks in Devflow UI.
No integration branch provided and BIA didn't detected any impacted services to deduce one. To get help about command usage, write If you need support, contact us on Slack #devflow with those details! |
|
/code revert-integration -b staging-43 |
|
View all feedbacks in Devflow UI.
Revert commits generated, trying to integrate them into
Commit 2da32f90e7 will soon be integrated into staging-43.
Commit 2da32f90e7 has been merged into staging-43 in merge commit b4e0c673a9. Check out the triggered pipeline on Gitlab 🦊 If you need to revert this integration, you can use the following command:
The changes from |
26e2c93 to
1c287af
Compare
Integrated commit sha: 2da32f9 Co-authored-by: dd-devflow[bot] <129370481+dd-devflow[bot]@users.noreply.github.com>
| if (isNodeEnvironment) { | ||
| return | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💬 suggestion: what about doing this check earlier in the init (like for logs)? a lot can happen before doInit is called
Motivation
The latest changes in Logs enable the SDK to function in Node environments. This side effect was unintended.
Changes
The PR introduces a condition that blocks SDK initialization in Node environments.
Test instructions
Compatibility test passed.
Checklist