Skip to content

Conversation

@mormubis
Copy link
Contributor

Motivation

The latest changes in Logs enable the SDK to function in Node environments. This side effect was unintended.

Changes

The PR introduces a condition that blocks SDK initialization in Node environments.

Test instructions

Compatibility test passed.

Checklist

  • Tested locally
  • Tested on staging
  • Added unit tests for this change.
  • Added e2e/integration tests for this change.

@cit-pr-commenter
Copy link

cit-pr-commenter bot commented Oct 16, 2025

Bundles Sizes Evolution

📦 Bundle Name Base Size Local Size 𝚫 𝚫% Status
Rum 162.85 KiB 162.95 KiB +104 B +0.06%
Rum Recorder 19.78 KiB 19.78 KiB 0 B 0.00%
Rum Profiler 4.89 KiB 4.89 KiB 0 B 0.00%
Logs 56.54 KiB 56.65 KiB +116 B +0.20%
Flagging 944 B 1020 B +76 B +8.05%
Rum Slim 119.81 KiB 119.90 KiB +93 B +0.08%
Worker 23.60 KiB 23.60 KiB 0 B 0.00%
🚀 CPU Performance
Action Name Base CPU Time (ms) Local CPU Time (ms) 𝚫%
RUM - add global context 0.0039 0.0046 +17.95%
RUM - add action 0.0114 0.0134 +17.54%
RUM - add error 0.011 0.0116 +5.45%
RUM - add timing 0.0025 0.0031 +24.00%
RUM - start view 0.0032 0.0033 +3.12%
RUM - start/stop session replay recording 0.0006 0.0008 +33.33%
Logs - log message 0.013 0.0146 +12.31%
🧠 Memory Performance
Action Name Base Memory Consumption Local Memory Consumption 𝚫
RUM - add global context 24.99 KiB 25.70 KiB +727 B
RUM - add action 45.96 KiB 92.91 KiB +46.95 KiB
RUM - add timing 25.19 KiB 24.78 KiB -420 B
RUM - add error 50.82 KiB 95.64 KiB +44.82 KiB
RUM - start/stop session replay recording 24.59 KiB 24.11 KiB -494 B
RUM - start view 421.45 KiB 442.60 KiB +21.15 KiB
Logs - log message 42.71 KiB 42.59 KiB -120 B

🔗 RealWorld

@datadog-official
Copy link

datadog-official bot commented Oct 16, 2025

⚠️ Tests

⚠️ Warnings

🧪 1 Test failed

rum resources › track concurrent fetch to same resource › async from rum/resources.scenario.ts (Datadog)
createTest.ts:244:3 async

[chromium] › ../lib/framework/createTest.ts:244:3 › rum resources › track concurrent fetch to same resource › async 

    Error: expect(received).toBeDefined()

    Received: undefined

       at rum/resources.scenario.ts:252

...

ℹ️ Info

❄️ No new flaky tests detected

🎯 Code Coverage
Patch Coverage: 71.43%
Total Coverage: 92.61% (-0.02%)

View detailed report

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 1c287af | Docs | Was this helpful? Give us feedback!

@mormubis mormubis marked this pull request as ready for review October 20, 2025 08:08
@mormubis mormubis requested a review from a team as a code owner October 20, 2025 08:08
@mormubis
Copy link
Contributor Author

/to-staging

1 similar comment
@mormubis
Copy link
Contributor Author

/to-staging

@dd-devflow-routing-codex
Copy link

dd-devflow-routing-codex bot commented Oct 20, 2025

View all feedbacks in Devflow UI.

2025-10-20 12:53:44 UTC ℹ️ Start processing command /to-staging


2025-10-20 12:53:52 UTC ℹ️ Branch Integration: starting soon, merge expected in approximately 0s (p90)

Commit 26e2c93cad will soon be integrated into staging-43.


2025-10-20 13:30:43 UTC ℹ️ Branch Integration: this commit was successfully integrated

Commit 26e2c93cad has been merged into staging-43 in merge commit ec3c412e7d.

Check out the triggered pipeline on Gitlab 🦊

If you need to revert this integration, you can use the following command: /code revert-integration -b staging-43

dd-mergequeue bot added a commit that referenced this pull request Oct 20, 2025
Integrated commit sha: 26e2c93

Co-authored-by: mormubis <[email protected]>
@thomas-lebeau
Copy link
Collaborator

/code revert-integration

@dd-devflow-routing-codex
Copy link

View all feedbacks in Devflow UI.

2025-10-21 11:57:24 UTC ℹ️ Start processing command /code revert-integration
If you need support, contact us on Slack #devflow!


2025-10-21 11:57:28 UTCDevflow: /code revert-integration

No integration branch provided and BIA didn't detected any impacted services to deduce one.

To get help about command usage, write /code revert-integration --help

If you need support, contact us on Slack #devflow with those details!

@thomas-lebeau
Copy link
Collaborator

/code revert-integration -b staging-43

@dd-devflow-routing-codex
Copy link

dd-devflow-routing-codex bot commented Oct 21, 2025

View all feedbacks in Devflow UI.

2025-10-21 11:58:19 UTC ℹ️ Start processing command /code revert-integration -b staging-43


2025-10-21 11:58:28 UTC ℹ️ Devflow:

Revert commits generated, trying to integrate them into staging-43...


2025-10-21 11:58:35 UTC ℹ️ Branch Integration: starting soon, merge expected in approximately 37m (p90)

Commit 2da32f90e7 will soon be integrated into staging-43.


2025-10-21 12:22:17 UTC ℹ️ Branch Integration: this commit was successfully integrated

Commit 2da32f90e7 has been merged into staging-43 in merge commit b4e0c673a9.

Check out the triggered pipeline on Gitlab 🦊

If you need to revert this integration, you can use the following command: /code revert-integration -b staging-43


2025-10-21 12:22:18 UTC ℹ️ Devflow: /code revert-integration -b staging-43

The changes from ec3c412e7d have been successfully reverted from staging-43.

dd-mergequeue bot added a commit that referenced this pull request Oct 21, 2025
Integrated commit sha: 2da32f9

Co-authored-by: dd-devflow[bot] <129370481+dd-devflow[bot]@users.noreply.github.com>
Comment on lines +104 to +106
if (isNodeEnvironment) {
return
}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💬 suggestion: ‏what about doing this check earlier in the init (like for logs)? a lot can happen before doInit is called

@mormubis mormubis marked this pull request as draft October 22, 2025 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants