Skip to content

Conversation

@leoromanovsky
Copy link
Contributor

@leoromanovsky leoromanovsky commented Jun 6, 2025

Motivation

The configuration was not matching up with the Precompute API response causing evaluations to not work correctly:


{
  "data": {
    "id": "test_subject",
    "type": "precomputed-assignments",
    "attributes": {
      "createdAt": 1749228397,
      "environment": {
        "name": "prod"
      },
      "flags": {
        "bugle": {
          "allocationKey": "allocation-default",
          "variationKey": "true",
          "variationType": "BOOLEAN",
          "variationValue": true,
          "extraLogging": {},
          "doLog": true,
          "reason": "TARGETING_MATCH"
        },
        "create-test-abin": {
          "allocationKey": "allocation-default",
          "variationKey": "true",
          "variationType": "BOOLEAN",
          "variationValue": true,
          "extraLogging": {},
          "doLog": true,
          "reason": "TARGETING_MATCH"
        },
...

Changes

  • falls back to precompute api v1 (the existing schema)
  • adds the configuration and wire test files; augments the tests

Test instructions

Checklist

  • Tested locally
  • Tested on staging
  • Added unit tests for this change.
  • Added e2e/integration tests for this change.

@cit-pr-commenter
Copy link

cit-pr-commenter bot commented Jun 6, 2025

Bundles Sizes Evolution

📦 Bundle Name Base Size Local Size 𝚫 𝚫% Status
Rum 146.75 KiB 146.75 KiB 0 B 0.00%
Rum Recorder 18.02 KiB 18.02 KiB 0 B 0.00%
Rum Profiler 4.63 KiB 4.63 KiB 0 B 0.00%
Logs 51.68 KiB 51.68 KiB 0 B 0.00%
Flagging 0 B 25.96 KiB 25.96 KiB N/A%
Rum Slim 106.38 KiB 106.38 KiB 0 B 0.00%
Worker 23.59 KiB 23.59 KiB 0 B 0.00%
🚀 CPU Performance
Action Name Base Average Cpu Time (ms) Local Average Cpu Time (ms) 𝚫
addglobalcontext 0.007 0.007 -0.000
addaction 0.028 0.023 -0.005
addtiming 0.007 0.005 -0.002
adderror 0.033 0.021 -0.012
startstopsessionreplayrecording 0.001 0.001 -0.000
startview 0.007 0.007 -0.000
logmessage 0.046 0.025 -0.021
🧠 Memory Performance
Action Name Base Consumption Memory (bytes) Local Consumption Memory (bytes) 𝚫 (bytes)
addglobalcontext 27.94 KiB 26.91 KiB -1059 B
addaction 56.00 KiB 54.34 KiB -1700 B
addtiming 28.66 KiB 25.53 KiB -3209 B
adderror 61.81 KiB 58.16 KiB -3731 B
startstopsessionreplayrecording 26.49 KiB 24.39 KiB -2148 B
startview 431.53 KiB 429.26 KiB -2319 B
logmessage 61.03 KiB 60.36 KiB -679 B

🔗 RealWorld

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.14%. Comparing base (32040be) to head (359ea48).

Additional details and impacted files
@@              Coverage Diff              @@
##           flagging-dev    #3613   +/-   ##
=============================================
  Coverage         92.14%   92.14%           
=============================================
  Files               326      326           
  Lines              8189     8189           
  Branches           1849     1849           
=============================================
  Hits               7546     7546           
  Misses              643      643           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@leoromanovsky leoromanovsky marked this pull request as ready for review June 6, 2025 17:53
@leoromanovsky leoromanovsky requested a review from a team as a code owner June 6, 2025 17:53
@leoromanovsky leoromanovsky requested review from typotter and removed request for a team June 6, 2025 17:53
@leoromanovsky
Copy link
Contributor Author

merging into dev branch since Tyler is ooo today; tagging mostly as a heads up. thanks!

@leoromanovsky leoromanovsky merged commit cbafc82 into flagging-dev Jun 6, 2025
17 checks passed
@leoromanovsky leoromanovsky deleted the lr/line-up-api branch June 6, 2025 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants