Skip to content

Conversation

@typotter
Copy link
Contributor

@typotter typotter commented Jun 5, 2025

Motivation

Want to connect the SDK to the ffe-service endpoint for precomputed assignments

Changes

  • fix the path portion
  • fixed path in INTEGRATION script
  • moved DD-API-TOKEN from URL to header
  • added content-type header

Test instructions

This branch is based on flagging-dev. Run the integration script and point it at the browser-flagging-package in web-ui as the destination.

Checklist

  • Tested locally
  • Tested on staging
  • Added unit tests for this change.
  • Added e2e/integration tests for this change.

@typotter typotter requested review from a team as code owners June 5, 2025 18:24
@typotter typotter changed the base branch from main to flagging-dev June 5, 2025 18:24
@typotter typotter requested a review from a team as a code owner June 5, 2025 18:24
@typotter typotter removed request for a team June 5, 2025 18:25
@typotter
Copy link
Contributor Author

typotter commented Jun 5, 2025

/merge

@dd-devflow
Copy link
Contributor

dd-devflow bot commented Jun 5, 2025

View all feedbacks in Devflow UI.

2025-06-05 18:49:00 UTC ℹ️ Start processing command /merge


2025-06-05 18:49:07 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in flagging-dev is approximately 0s (p90).


2025-06-05 18:49:30 UTC ℹ️ MergeQueue: This merge request was already merged

This pull request was merged directly.

@typotter typotter merged commit 4e26ca5 into flagging-dev Jun 5, 2025
2 of 14 checks passed
@typotter typotter deleted the typo/fix-flagging-api-path branch June 5, 2025 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants