soc/intel/meteorlake: Hook the VT-d DMA protection option #553
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Michał Żygowski <[email protected]> Signed-off-by: Filip Gołaś <[email protected]>
Contributor
Author
|
After applying the patch |
Contributor
|
The change is correct, however if the FSP does not produce the HOB, then there is not much we can do about it... |
mkopec
approved these changes
Sep 9, 2024
Member
mkopec
left a comment
mkopec
left a comment
There was a problem hiding this comment.
Change looks good, actual DMA protection will work once it's fixed in FSP
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Applied Miczyg1's patch to coreboot alder lake https://review.coreboot.org/c/coreboot/+/68450 to meteor lake. It should hopefully fix this issue Dasharo/dasharo-issues#985 but I can't test it now because of missing FSP.