Provide QueryAsync for CommandDefinition with an arbitrary number of input types #1608
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves #1181.
The issue points out that the overload of QueryAsync that supports an arbitrary number of types does not support receiving a CancellationToken. @NickCraver rightly points out that fixing this directly would be a breaking change.
This PR addresses the same problem in a different way, which is a simple non-breaking change, as suggested by @AndreaCuneo. It introduces an additional overload of QueryAsync taking CommandDefinition and is consistent with other QueryAsync overloads that support CommandDefinition.