Fix trace tests with x87 floating point #1153
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Annoyingly the stdout and stderr seem to be interleaved, but it's better than nothing.
With SSE disabled, the default tolerance of EXPECT_FLOAT_EQ was too tight for some tests to pass. (The non-SSE results are probably actually closer to the true value; the difference probably arises from using 80-bit-precision x87 operations). The expected value was set by just running the code and seeing what it output. Independent of compiler or OS, the x87-based results appear to form a separate cluster from the SSE ones. Also test the plane returned by the trace in a couple tests.
DolceTriade
approved these changes
May 18, 2024
This was referenced Jun 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes CM unit tests breaking with SSE disabled, as reported by @illwieckz.