-
Notifications
You must be signed in to change notification settings - Fork 17
feat(dt-utils): refactor the dt-utils #105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
文档里面 github icon 的链接能否设置为 dt-utils 的 github 链接
d8de76a
to
f9fb886
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
想到一个问题,这个里面有些 console 是用中文写的,可能源码合并到产品里面之后,中文校验不通过
@@ -0,0 +1,28 @@ | |||
import { nanoid } from 'nanoid'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这个是否需要单元测试啊
export { default as dayjs } from 'dayjs'; | ||
export * as idb from 'idb'; | ||
export { default as Cookie } from 'js-cookie'; | ||
export * as lodash from 'lodash-es'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这些是为了以后大家都走 utils 引入吗?
* @see {@link https://developer.mozilla.org/en-US/docs/Web/API/IndexedDB_API/Using_IndexedDB|MDN IndexedDB 使用指南} | ||
* @see {@link https://caniuse.com/#feat=indexeddb|浏览器兼容性} | ||
*/ | ||
class IndexedDB { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这个单元测试需要吗?
/** | ||
* IndexedDB | ||
* | ||
* @deprecated |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
是打了移除标记吗?
变更类型
请选择以下选项以描述 PR 的类型:
相关问题
变更内容
优化
新增
对应 Previewer
https://jin-sir.github.io/dt-utils/