-
Notifications
You must be signed in to change notification settings - Fork 11
Improves price display and customer market handling #57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
danisal
wants to merge
14
commits into
main
Choose a base branch
from
feat/prices
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added support for displaying lowest and highest prices, with comparisons reflected in the UI. - Defined pricing logic in a utility function and integrated customer market identification and management. - Enhanced GraphQL queries to include dynamic price and market data handling.
- The markets API route was deleted as it is no longer needed. - This cleanup helps streamline the codebase and remove redundant functionality.
- Integrated the `getPrice` utility to calculate and display variant prices dynamically. - This ensures accurate pricing by considering base, selected, and market prices. - Updated `Price` component usage to reflect the new price structure.
- Introduce environment variables for price-related configurations: `CRYSTALLIZE_MARKETS_PRICE`, `CRYSTALLIZE_SELECTED_PRICE`, and `CRYSTALLIZE_BASE_PRICE`. - Enhance the `price` field structure to support additional attributes, improving flexibility and clarity in price handling.
- Previously, discount percentages were not properly rounded, which could lead to minor display inconsistencies. - This update ensures the percentages are rounded to two decimal places for improved accuracy and presentation.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enhances the price display logic and ensures accurate price calculations across different markets.