Skip to content
This repository was archived by the owner on Nov 9, 2019. It is now read-only.

Conversation

@marmistrz
Copy link
Member

I'd like to merge it before we land any kind of socket-related code. The absence of non-regular files on Windows makes it much easier to implement poll_oneoff on Windows.

Tasks:

  • Refactor the code to share common parts across platforms
  • Actually implement poll_oneoff on Windows.

@kubkon
Copy link
Member

kubkon commented Oct 22, 2019

@marmistrz could you put the refactoring bit on hold until #137 lands? I envision some major changes to come out of that and wouldn't want you to spend too much time on refactoring potentially dead code.

@marmistrz
Copy link
Member Author

@kubkon yes. I've just realized that my Windows implementation is kind of blocked by #137 too.

@kubkon
Copy link
Member

kubkon commented Oct 22, 2019

@kubkon yes. I've just realized that my Windows implementation is kind of blocked by #137 too.

Yeah, my apologies for that! I'll try to merge #137 ASAP so as not to block you! :-)

@marmistrz marmistrz changed the title Refactor poll_oneoff on Unix and implement it on Windows. Refactor poll_oneoff on Unix for easier implementation on Windows. Oct 24, 2019
@marmistrz
Copy link
Member Author

Closing in favor of #137.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants