-
-
Couldn't load subscription status.
- Fork 151
Remove "done!" notification #241
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
I think way better way would be to remove the notify completely from where its being called now and just set default callback (thats currently by default nil) to be function that calls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As i said in my response, should just be callback imo
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
I believe just not setting the default callback is better; removed the notify completely! |
|
Yea i agree, much cleaner solution |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see comments
|
@all-contributors add @D7ry for code. |
|
I've put up a pull request to add @D7ry! 🎉 |
By configuring
notify_donevariable in opts, users can disable the "done!" notification that some may find a bit distracting.