This repository was archived by the owner on Jan 18, 2022. It is now read-only.
[PAN-3111] Moves getTransactionReceipt from eea to priv #42
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josh-richardson
changed the title
iikirilov
reviewed
Sep 16, 2019
antonydenyer
approved these changes
Sep 16, 2019
MadelineMurray
suggested changes
Sep 19, 2019
Contributor
MadelineMurray
left a comment
MadelineMurray
left a comment
There was a problem hiding this comment.
When I tried to run deployContract.js with these changes, I got the following error:
TypeError: web3.eea.getTransactionReceipt is not a function
at getPrivateContractAddress (/Users/madelinemurray/eeajs/example/multiNodeExample/deployContract.js:29:6)
at process._tickCallback (internal/process/next_tick.js:68:7)
Are there more updates needed to the actual examples themselves?
Contributor
Author
|
@MadelineMurray good call. I've updated, but some of the integration tests still fail here as pantheon-quickstart is still outdated and the PR to move getTransactionReceipt from eea to priv hasn't yet been merged. |
Contributor
Author
|
Quickstart has now been updated and all of the integration tests now pass. This can be merged. |
MadelineMurray
approved these changes
Sep 27, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Renames EeaGetTransactionReceipt to PrivGetTransactionReceipt
The relevant PR in Pantheon and the issue:
PegaSysEng/pantheon#1927
https://pegasys1.atlassian.net/secure/RapidBoard.jspa?rapidView=57&projectKey=PAN&modal=detail&selectedIssue=PAN-3111