Skip to content

Conversation

@ErikEJ
Copy link
Contributor

@ErikEJ ErikEJ commented Oct 26, 2025

Closes #926

PR Checklist

  • Created a feature/dev branch in your fork (vs. submitting directly from a commit on main)
  • Based off latest main branch of toolkit
  • PR doesn't include merge commits (always rebase on top of our main, if needed)
  • Contains NO breaking changes
  • Every new API (including internal ones) has full XML docs
  • Code follows all style conventions

Other information

Copilot AI review requested due to automatic review settings October 26, 2025 10:17
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR reverts the Microsoft.SqlServer.DacFx package from version 170.2.70 back to version 170.1.61 to address compatibility or stability issues identified in issue #926.

Key Changes:

  • Downgrade Microsoft.SqlServer.DacFx package version from 170.2.70 to 170.1.61

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.

@ErikEJ
Copy link
Contributor Author

ErikEJ commented Oct 26, 2025

Bug confirmed by using 9.8.0 and then adding this to my AppHost 😢

<PackageReference Include="Microsoft.SqlServer.DacFx" Version="170.2.70" />

@aaronpowell
Copy link
Member

Bug confirmed by using 9.8.0 and then adding this to my AppHost 😢

<PackageReference Include="Microsoft.SqlServer.DacFx" Version="170.2.70" />

I'll merge this and cut a new release, 9.9.0

@ErikEJ
Copy link
Contributor Author

ErikEJ commented Oct 27, 2025

@aaronpowell Thanks, only an issue in 9.8.1-beta though

@ErikEJ
Copy link
Contributor Author

ErikEJ commented Oct 27, 2025

Ah, you merged the locator fix.

@aaronpowell
Copy link
Member

Ah, you merged the locator fix.

oh, was that not ready?

@ErikEJ
Copy link
Contributor Author

ErikEJ commented Oct 27, 2025

@aaronpowell It was ready!

Copy link
Contributor

@jmezach jmezach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ErikEJ ErikEJ merged commit 7d234de into CommunityToolkit:main Oct 27, 2025
209 of 210 checks passed
@ErikEJ
Copy link
Contributor Author

ErikEJ commented Oct 27, 2025

@jmezach @aaronpowell Confirmed that build 9.8.1-beta.420 works as expected

And using WithSkipWhenDeployed() on my smoke test App Host with 4 database projects the dependent web API apps are now ready in 1 second versus 30 seconds!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

SQL Database Publish fails with latest beta

3 participants