MCP Inspector test stability #923
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR enhances the stability of MCP Inspector tests by improving diagnostic capabilities when tests fail. The changes add npm logging infrastructure to capture detailed information about npm operations during test failures.
- Adds npm log directory configuration with verbose logging for Node.js-related tests
- Implements artifact upload for npm logs when test workflows fail
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
.github/workflows/tests.yaml |
Adds artifact upload step to capture npm logs on test failure |
.github/actions/setup-runtimes-caching/action.yml |
Configures npm with verbose logging and dedicated log directory for Node.js tests |
| run: | | ||
| mkdir -p ./.npm-logs | ||
| npm config set loglevel verbose | ||
| npm config set prefix './.npm-logs' |
There was a problem hiding this comment.
Setting npm prefix to ./.npm-logs changes the global package installation directory, which can break npm operations. This should be npm config set cache './.npm-logs' instead to set the cache directory where logs are stored.
Suggested change
| npm config set prefix './.npm-logs' | |
| npm config set cache './.npm-logs' |
aaronpowell
temporarily deployed
to
azure-artifacts
GitHub Actions
Inactive
aaronpowell
temporarily deployed
to
azure-artifacts
GitHub Actions
Inactive
aaronpowell
temporarily deployed
to
azure-artifacts
GitHub Actions
Inactive
aaronpowell
had a problem deploying
to
azure-artifacts
GitHub Actions
Error
Contributor
Minimum allowed line rate is |
aaronpowell
temporarily deployed
to
azure-artifacts
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.