Attempt to fix issue #913 #921
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR addresses issue #913 by enabling MSBuild to query all .NET SDK locations when locating MSBuild instances. The change sets AllowQueryAllDotnetLocations to true immediately after registering MSBuild defaults in the static constructor of SqlProjectBuilderExtensions.
- Enables comprehensive .NET SDK location querying for MSBuild discovery
- Single-line change to the MSBuild registration initialization logic
jmezach
reviewed
Oct 23, 2025
src/CommunityToolkit.Aspire.Hosting.SqlDatabaseProjects/SqlProjectBuilderExtensions.cs
Show resolved
Hide resolved
Contributor
Author
|
@aaronpowell MCP inspector test is very flaky 😢 |
Member
yep, got another PR to hopefully sort that out |
aaronpowell
approved these changes
Oct 27, 2025
Contributor
Contributor
Author
|
@jmezach No, unsure what is needed to repro actually. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #913
PR Checklist
Other information