Add WithLogLevel extension method #884
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaronpowell
approved these changes
Oct 13, 2025
Member
aaronpowell
left a comment
aaronpowell
left a comment
There was a problem hiding this comment.
Just got one question about a change that I'm unsure if it's meant to be related or not - otherwise it's good to merge in.
| .WithEntrypoint("/go-feature-flag") | ||
| .WithArgs(args) | ||
| .WithOtlpExporter(); | ||
| .WithArgs(args); |
Member
There was a problem hiding this comment.
So we won't do OTEL wire-up initially?
Contributor
Author
There was a problem hiding this comment.
Well, I have an issue with the new tests. Some dependencies that are not registered, so I had to remove this to ensure my tests are passing. Also, I still have an issue with the collector so I suppose removing it seems better.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #827, add a
WithLogLevelextension method for the following integration:PR Checklist
Other information