Skip to content

Conversation

@martinjt
Copy link
Contributor

Adds an internal healthcheck to the Collector container. This uses a non-default port, and adds a new extension so it doesn't interfere with any components the user has specified. This also enables the "merge and append" feature flag.

PR Checklist

  • Created a feature/dev branch in your fork (vs. submitting directly from a commit on main)
  • Based off latest main branch of toolkit
  • PR doesn't include merge commits (always rebase on top of our main, if needed)
  • Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Contains NO breaking changes
  • Every new API (including internal ones) has full XML docs
  • Code follows all style conventions

Copilot AI review requested due to automatic review settings September 14, 2025 20:30
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds an internal health check capability to the OpenTelemetry Collector container, providing better monitoring and status visibility within the Aspire dashboard. The implementation uses a dedicated non-default port and configurable extension to avoid conflicts with user-specified components.

  • Adds a new DisableHealthcheck setting to allow users to opt out of the health check functionality
  • Implements health check endpoint configuration on port 13233 with the /health path
  • Enables the "merge and append" feature flag for OpenTelemetry Collector configuration

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
OpenTelemetryCollectorSettings.cs Adds DisableHealthcheck property to control health check behavior
OpenTelemetryCollectorExtensions.cs Implements health check endpoint configuration and feature flag enablement

@martinjt
Copy link
Contributor Author

Needs tests and some other stuff by the looks of it, I'll sort those tomorrow.

Copy link
Member

@aaronpowell aaronpowell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wanna add a test on this?

I should have read comments first 😅

@github-actions github-actions bot added the Stale label Sep 21, 2025
@aaronpowell aaronpowell added this to the 9.8 milestone Sep 24, 2025
@github-actions github-actions bot removed the Stale label Sep 24, 2025
@martinjt martinjt force-pushed the add-collector-healthcheck branch from 03f6b34 to 9429080 Compare September 25, 2025 12:43
@martinjt martinjt force-pushed the add-collector-healthcheck branch from 9429080 to d430a9b Compare September 25, 2025 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants