-
Couldn't load subscription status.
- Fork 131
Added a healthcheck to the OpenTelemetry Collector container #858
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added a healthcheck to the OpenTelemetry Collector container #858
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds an internal health check capability to the OpenTelemetry Collector container, providing better monitoring and status visibility within the Aspire dashboard. The implementation uses a dedicated non-default port and configurable extension to avoid conflicts with user-specified components.
- Adds a new
DisableHealthchecksetting to allow users to opt out of the health check functionality - Implements health check endpoint configuration on port 13233 with the
/healthpath - Enables the "merge and append" feature flag for OpenTelemetry Collector configuration
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| OpenTelemetryCollectorSettings.cs | Adds DisableHealthcheck property to control health check behavior |
| OpenTelemetryCollectorExtensions.cs | Implements health check endpoint configuration and feature flag enablement |
src/CommunityToolkit.Aspire.Hosting.OpenTelemetryCollector/OpenTelemetryCollectorExtensions.cs
Show resolved
Hide resolved
|
Needs tests and some other stuff by the looks of it, I'll sort those tomorrow. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wanna add a test on this?
I should have read comments first 😅
03f6b34 to
9429080
Compare
9429080 to
d430a9b
Compare
Adds an internal healthcheck to the Collector container. This uses a non-default port, and adds a new extension so it doesn't interfere with any components the user has specified. This also enables the "merge and append" feature flag.
PR Checklist