Fix Otel Collector on Windows #853
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Rewrite all resources with the `OtlpExporterAnnotation`, not just project resources 2. Call into `WithOpenTelemetryCollectorRouting` to ensure logic remains consistent between the two approaches of wiring up telemetry
martinjt
approved these changes
Sep 14, 2025
src/CommunityToolkit.Aspire.Hosting.OpenTelemetryCollector/OpenTelemetryCollectorExtensions.cs
Show resolved
Hide resolved
tests/CommunityToolkit.Aspire.Hosting.OpenTelemetryCollector.Tests/ResourceCreationTests.cs
Outdated
Show resolved
Hide resolved
afscrome
force-pushed
the
otel-collector
branch
from
b84fc83 to
f07086b
Compare
martinjt
reviewed
Sep 14, 2025
tests/CommunityToolkit.Aspire.Hosting.OpenTelemetryCollector.Tests/ResourceCreationTests.cs
Show resolved
Hide resolved
1 task
|
@aaronpowell Can we merge this? |
This was referenced Sep 26, 2025
FullStackChef
pushed a commit
to FullStackChef/CommunityToolkit-Aspire
that referenced
this pull request
Sep 26, 2025
* Fix Otel Collector dev cert path calculation to work when host is windows. * Use `HostUrl` to contextually resolve the aspire dashboard url within a container. * Refactor `WithAppForwarding` 1. Rewrite all resources with the `OtlpExporterAnnotation`, not just project resources 2. Call into `WithOpenTelemetryCollectorRouting` to ensure logic remains consistent between the two approaches of wiring up telemetry * Update `ContainerHasAspireEnvironmentVariables` to evaluate final env vars.
This was referenced Sep 29, 2025
This was referenced Oct 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #852
Fixes: https://discord.com/channels/1361488941836140614/1375617984512528567/1414908067518222369
Fixes: https://discord.com/channels/1361488941836140614/1375617984512528567/1415839400901738616
Partly Fixes: https://discord.com/channels/1361488941836140614/1375617984512528567/1414909111987998753, although the fix may not fully work until dotnet/aspire#6547 is resolved
Path.Combinewhen calculating container paths for certs -Path.Combineuses the host OS's path separator, but these values MUST use unix style path separators.HostUrlto resolve the Aspire Dashboard url in the context of the otel container (i.e. handling anyhost.docker.internaltranslation)WithAppForwardingto use the globalBeforeStartEventrather than resource specific events - this avoids race conditions of other resources starting up whilst the otel collector starts up.PR Checklist
Other information