Support SSV API URLs without trailing slashes #396
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ltitanb
approved these changes
Oct 22, 2025
nilsfs7
pushed a commit
to nilsfs7/commit-boost-client
that referenced
this pull request
Oct 27, 2025
nilsfs7
pushed a commit
to nilsfs7/commit-boost-client
that referenced
this pull request
Oct 27, 2025
jclapis
added a commit
that referenced
this pull request
Nov 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SSV's default API URL in v0.9.0 is
https://api.ssv.network/api/v4(with no trailing slash), and Rust's URL joiner will interpret this as a file and discard it duringjoin()operations. This fixes the issue where it matters (infetch_ssv_pubkeys()) by ensuring that the end is always interpreted as a directory rather than a file.We could also put checks on the initial config loader, since there's never really a valid reason to have an SSV API URL without a trailing slash as they're always going to be appended to, but either way this ensures that keys will always be fetched correctly.