Add IP / Port Settings to Signer #305
Merged
+104
−29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…he source" This reverts commit 58c6117.
jclapis
force-pushed
the
add-ip-bind-to-signer
branch
from
2e2ba3b to
c0f591d
Compare
ltitanb
requested changes
Jun 8, 2025
Collaborator
ltitanb
left a comment
ltitanb
left a comment
There was a problem hiding this comment.
looks good overall! some small comments, also could you please update the config.example.toml ?
Co-authored-by: ltitanb <[email protected]>
…ip-bind-to-signer
Collaborator
Author
Done in 7afb763. |
ltitanb
approved these changes
Jun 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
signermodule currently hardcodes the IP it binds to as0.0.0.0, and the port isn't able to be specified in the configuration file - it's only pulled from an environment variable. In Docker mode it doesn't matter, but that's not ideal for people running natively that want to restrict the traffic tolocalhostsince it will open up the Signer API to the entire network.This modifies it to match PBS's setup, where
host(IP) andportare both configuration variables. Users can manually override the combo with theCB_SIGNER_ENDPOINTenvironment variable which is an analog of the PBS one. It also specifies a default signer host (localhost) and port (20000) in case the configuration parameters are unset and the environment variable isn't present.