Skip to content

Vue expose #4265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 4, 2025
Merged

Vue expose #4265

merged 3 commits into from
Jul 4, 2025

Conversation

jtydhr88
Copy link
Collaborator

@jtydhr88 jtydhr88 commented Jun 25, 2025

re-sent and enable Vue expose for custom nodes
Also as practiced in a real vue-based project, it is necessary to expose defineStore to allow pinia.for custom nodes, which reverted in #4027 before

┆Issue is synchronized with this Notion page by Unito

@jtydhr88 jtydhr88 requested a review from a team as a code owner June 25, 2025 00:10
Copy link
Contributor

@webfiltered webfiltered left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just addressed the direct defineStore expose - can come back and review properly once we have a solution for that!

Copy link
Contributor

@christian-byrne christian-byrne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The past bugs have been confirmed resolved. We should merge this so we can get some coverage and see if any new bugs exist.

This PR is necessary for various things such as vue extensions.

@christian-byrne christian-byrne merged commit ee50885 into main Jul 4, 2025
10 checks passed
@christian-byrne christian-byrne deleted the vue-expose-local branch July 4, 2025 04:35
comfy-jinyi pushed a commit that referenced this pull request Jul 4, 2025
This was referenced Jul 9, 2025
benceruleanlu pushed a commit that referenced this pull request Jul 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants