Skip to content

[Test] Update template expectations #4134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Conversation

webfiltered
Copy link
Contributor

@webfiltered webfiltered commented Jun 11, 2025

Updates test expectations for templates 0.1.27

┆Issue is synchronized with this Notion page by Unito

@webfiltered webfiltered added the New Browser Test Expectations New browser test screenshot should be set by github action label Jun 11, 2025
@github-actions github-actions bot requested a review from a team as a code owner June 11, 2025 13:42
@webfiltered webfiltered marked this pull request as draft June 11, 2025 13:47
@christian-byrne
Copy link
Contributor

@webfiltered Can we just merge this for the time being so other PRs don't have failing tests? Then we can revert later if needed?

@webfiltered
Copy link
Contributor Author

Just need to merge the new templates into core instead. They're done apparently. This can be closed then.

@christian-byrne
Copy link
Contributor

That may take multiple more days though. It's current 1:20 am CST, and the PR in core might take a while. For the sake of technical accuracy, this PR should theoretically be merged.

@webfiltered
Copy link
Contributor Author

Why would it take multiple more days? We can just revert the template update if that's the case.

@webfiltered
Copy link
Contributor Author

comfyanonymous/ComfyUI#8502 - sorted.

@webfiltered
Copy link
Contributor Author

Resolved - see prev. comment.

@webfiltered webfiltered deleted the template-expectations branch June 14, 2025 04:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
New Browser Test Expectations New browser test screenshot should be set by github action
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants