honor user-specified full-screen presentation options #553
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
NB the apple bug only affects notched screens for some reason; it works fine if you're fullscreening on a non-notched displays. I've filed FB9745661 with Apple about the issue, but they didn't fix it in 12.1, at least… |
|
Anything I can do to make merging this more likely? :) |
|
Not really, Mike will merge when he has time to focus on it. Patience is required. |
|
Thank you for your contribution. :) |
emsquared
added a commit
that referenced
this pull request
Mar 14, 2023
honor user-specified full-screen presentation options
|
@emsquared I missed this when it happened, thank you for landing this change! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now on a notchbook, if you disable the global preference "Automatically hide menubar in fullscreen", Textual ignores this and automatically hides the menubar no matter what. Personally I leave this off when using my laptop without an external display (because due to an Apple bug, hiding the menu bar disables the ⌘? shortcut which allows me to type the name of menu items, and "⌘? Connect ⬇️⏎" is a pretty common thing for me to do, particularly when untethered).
Here's one possible fix; I've tested it locally and it fixes it for me. I'm not sure that this is the one you'd actually want to use, since possibly this method was overridden for a reason, but paying attention to the input
proposedOptionsmask seems like it's probably a good idea in some way.