fixes #4 #5
Merged
fixes #4 #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…es are mismatched
AlexSkrypnyk
approved these changes
Jun 6, 2018
|
Please merge this as the package is currently unusable if you don't care about the message. And |
|
This assertion loses its value without this fix. Currently, you would have to define a message in the assertion in order for it to pass. At the same time, this message is being transformed to lowercase, so the actual thrown exception has to be lowercase, too. Please merge it! 👍 |
|
@DavertMik please ? |
|
No chance... the maintainers don't care about this :) Complete ignorance. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4