Skip to content

Conversation

ghost
Copy link

@ghost ghost commented Sep 2, 2020

  • Added two new assertions assertDoesNotThrow and assertDoesNotThrowWithMessage.
  • Updated documentation and corresponding tests.
  • Now these assertions can be used with callable functions that expect parameters!
  • Removed support for PHPUnit 6 version, since functionalities present since PHP 7.1 were required.
  • Added phpunit.xml file.
  • Test on php 7.3 and 7.4 .

Note 1: this should be tagged as version 1.1.x or 2.x to allow people using PHPUnit 6 to stay 1.0.x
Note 2: These changes would allow adding this library as a dependency in 'Verify' and eliminate this possible duplicate code.

@Naktibalda waiting for review.

@ghost ghost changed the title Added assertDoesNotThrow* assertions Added assertDoesNotThrow* assertions (and more) Sep 3, 2020
@Naktibalda Naktibalda requested a review from DavertMik September 6, 2020 06:50
@DavertMik
Copy link
Member

Thank you! Looks good to me

@DavertMik
Copy link
Member

DavertMik commented Oct 2, 2020

I think we can tag this 1.1

@DavertMik DavertMik merged commit 2e30869 into Codeception:master Oct 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants